update README

fix issue with VM instacne types returning prematurely

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "proxmoxaas-common-lib"]
+	path = proxmoxaas-common-lib
+	url = https://git.tronnet.net/tronnet/proxmoxaas-common-lib

Makefile

@@ -1,11 +1,11 @@
-.PHONY: build test clean
+.PHONY: build clean
 
 build: clean
+	@echo "======================== Building Binary ======================="
+	mkdir -p dist
 	CGO_ENABLED=0 go build -ldflags="-s -w" -v -o dist/ .
 
-test: clean
-	go run .
-
 clean:
+	@echo "======================== Cleaning Project ======================"
 	go clean
-	rm -f dist/*
+	rm -rf dist/*

Readme.md

@@ -0,0 +1,16 @@
+# ProxmoxAAS Fabric - In-Memory Cache for ProxmoxAAS Cluster State
+ProxmoxAAS Fabric provides functionality for the API by caching an in-memory representation of the proxmox cluster's state which speeds up computation of resource usage statistics.
+
+## Installation
+
+### Prerequisites
+- [ProxmoxAAS-API](https://git.tronnet.net/tronnet/ProxmoxAAS-API)
+- Proxmox VE Cluster (v7.0+)
+
+### Installation - API
+1. Download `proxmoxaas-fabric` binary and `template.config.json` file from releases
+2. Rename `template.config.json` to `config.json` and modify the following values:
+    1. `listenPort`: port for proxmoxaas-fabric to bind and listen on
+    2. `url`: url to the Proxmox API, ie  `https://pve.domain.net/api2/json`
+    3. `token`: the `proxmoxaas-api` API token user(name), authentication realm (pam), token id, and token secrey key (uuid)
+    4. `rebuildInterval` (***optional***): the interval on which to completely rebuild the cache

app/app.go

@@ -6,42 +6,42 @@ import (
 	"fmt"
 	"log"
 	"net/http"
+	paas "proxmoxaas-fabric/proxmoxaas-common-lib"
 	"strconv"
 	"time"
 
-	"github.com/gin-gonic/gin"
 	"github.com/luthermonson/go-proxmox"
 )
 
-const APIVersion string = "0.0.3"
+const APIVersion string = "1.0.0"
 
 var client ProxmoxClient
 
 func Run() {
 	gob.Register(proxmox.Client{})
-	gin.SetMode(gin.ReleaseMode)
 
 	configPath := flag.String("config", "config.json", "path to config.json file")
 	flag.Parse()
 
 	config := GetConfig(*configPath)
-	log.Printf("Initialized config from %s", *configPath)
+	log.Printf("[INFO] initialized config from %s", *configPath)
 
-	token := fmt.Sprintf(`%s@%s!%s`, config.PVE.Token.USER, config.PVE.Token.REALM, config.PVE.Token.ID)
+	token := fmt.Sprintf(`%s@%s!%s`, config.PVE.Token.User, config.PVE.Token.Realm, config.PVE.Token.ID)
 	client = NewClient(config.PVE.URL, token, config.PVE.Token.Secret)
 
-	router := gin.Default()
+	router := http.NewServeMux()
 
 	cluster := Cluster{}
 	cluster.Init(client)
-	start := time.Now()
-	log.Printf("Starting cluster sync\n")
-	cluster.Sync()
-	log.Printf("Synced cluster in %fs\n", time.Since(start).Seconds())
+	log.Printf("[INFO] starting cluster sync\n")
+	err := cluster.Sync()
+	if err != nil {
+		log.Printf("[ERR ] error encountered while syncing cluster: %s", err)
+	}
 
 	// set repeating update for full rebuilds
 	ticker := time.NewTicker(time.Duration(config.ReloadInterval) * time.Second)
-	log.Printf("Initialized cluster sync interval of %ds", config.ReloadInterval)
+	log.Printf("[INFO] initialized cluster sync interval of %ds", config.ReloadInterval)
 	channel := make(chan bool)
 	go func() {
 		for {
@@ -49,135 +49,128 @@ func Run() {
 			case <-channel:
 				return
 			case <-ticker.C:
-				start := time.Now()
-				log.Printf("Starting cluster sync\n")
-				cluster.Sync()
-				log.Printf("Synced cluster in %fs\n", time.Since(start).Seconds())
+				log.Printf("[INFO] starting cluster sync\n")
+				err := cluster.Sync()
+				if err != nil {
+					log.Printf("[ERR ] error encountered while syncing cluster: %s", err)
+				}
 			}
 		}
 	}()
 
-	router.GET("/version", func(c *gin.Context) {
+	router.HandleFunc("GET /version", func(w http.ResponseWriter, r *http.Request) {
 		PVEVersion, err := client.Version()
 		if err != nil {
-			c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
+			paas.HTTPWriteJson(w, http.StatusInternalServerError, map[string]any{"error": err.Error()})
 		} else {
-			c.JSON(http.StatusOK, gin.H{"api-version": APIVersion, "pve-version": PVEVersion})
+			paas.HTTPWriteJson(w, http.StatusOK, map[string]any{"api-version": APIVersion, "pve-version": PVEVersion})
 		}
 	})
 
-	router.GET("/nodes/:node", func(c *gin.Context) {
-		nodeid := c.Param("node")
-
-		node, err := cluster.GetNode(nodeid)
-
+	router.HandleFunc("GET /", func(w http.ResponseWriter, r *http.Request) {
+		callback := Callback{}
+		v, err := GetCluster(&callback, &cluster)
 		if err != nil {
-			c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
+			paas.HTTPWriteJson(w, http.StatusInternalServerError, map[string]any{"error": err.Error()})
+		} else {
+			paas.HTTPWriteJson(w, http.StatusOK, map[string]any{"cluster": v})
+		}
+		callback.Invoke()
+	})
+
+	router.HandleFunc("GET /nodes/{node}", func(w http.ResponseWriter, r *http.Request) {
+		nodeid := r.PathValue("node")
+		callback := Callback{}
+		node, err := GetNode(&callback, &cluster, nodeid)
+		if err != nil {
+			paas.HTTPWriteJson(w, http.StatusNotFound, map[string]any{"error": err.Error()})
+		} else {
+			paas.HTTPWriteJson(w, http.StatusOK, map[string]any{"node": node})
+		}
+		callback.Invoke()
+	})
+
+	router.HandleFunc("GET /nodes/{node}/instances/{vmid}", func(w http.ResponseWriter, r *http.Request) {
+		nodeid := r.PathValue("node")
+		vmid, err := strconv.ParseUint(r.PathValue("vmid"), 10, 64)
+		if err != nil {
+			paas.HTTPWriteJson(w, http.StatusBadRequest, map[string]any{"error": fmt.Sprintf("%s could not be converted to vmid (uint)", r.PathValue("instance"))})
+			return
+		}
+		callback := Callback{}
+		instance, err := GetInstance(&callback, &cluster, nodeid, vmid)
+		if err != nil {
+			paas.HTTPWriteJson(w, http.StatusNotFound, map[string]any{"error": err.Error()})
+		} else {
+			paas.HTTPWriteJson(w, http.StatusOK, map[string]any{"instance": instance})
+		}
+		callback.Invoke()
+	})
+
+	router.HandleFunc("POST /sync", func(w http.ResponseWriter, r *http.Request) {
+		log.Printf("[INFO] starting cluster sync\n")
+		err := cluster.Sync()
+		if err != nil {
+			log.Printf("[ERR ] failed to sync cluster: %s", err)
+			paas.HTTPWriteJson(w, http.StatusInternalServerError, map[string]any{"error": err.Error()})
 			return
 		} else {
-			c.JSON(http.StatusOK, gin.H{"node": node})
 			return
 		}
 	})
 
-	router.GET("/nodes/:node/devices", func(c *gin.Context) {
-		nodeid := c.Param("node")
+	router.HandleFunc("POST /nodes/{node}/sync", func(w http.ResponseWriter, r *http.Request) {
+		nodeName := r.PathValue("node")
 
-		node, err := cluster.GetNode(nodeid)
+		log.Printf("[INFO] starting %s sync\n", nodeName)
 
+		callback := Callback{}
+		node, err := GetNode(&callback, &cluster, nodeName)
 		if err != nil {
-			c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-			return
-		} else {
-			c.JSON(http.StatusOK, gin.H{"devices": node.Devices})
+			log.Printf("[ERR ] failed to sync %s: %s", nodeName, err.Error())
+			paas.HTTPWriteJson(w, http.StatusNotFound, map[string]any{"error": err.Error()})
+			callback.Invoke()
 			return
 		}
+		callback.Invoke()
+
+		err = node.Sync()
+		if err != nil {
+			log.Printf("[ERR ] failed to sync %s: %s", nodeName, err.Error())
+			paas.HTTPWriteJson(w, http.StatusNotFound, map[string]any{"error": err.Error()})
+		}
 	})
 
-	router.GET("/nodes/:node/instances/:vmid", func(c *gin.Context) {
-		nodeid := c.Param("node")
-		vmid, err := strconv.ParseUint(c.Param("vmid"), 10, 64)
+	router.HandleFunc("POST /nodes/{node}/instances/{vmid}/sync", func(w http.ResponseWriter, r *http.Request) {
+		nodeName := r.PathValue("node")
+		vmid, err := strconv.ParseUint(r.PathValue("vmid"), 10, 64)
 		if err != nil {
-			c.JSON(http.StatusInternalServerError, gin.H{"error": fmt.Sprintf("%s could not be converted to vmid (uint)", c.Param("instance"))})
+			log.Printf("[ERR ] failed to sync %s.%d: %s", nodeName, vmid, err.Error())
+			paas.HTTPWriteJson(w, http.StatusInternalServerError, map[string]any{"error": fmt.Sprintf("%s could not be converted to vmid (uint)", r.PathValue("instance"))})
 			return
 		}
 
-		node, err := cluster.GetNode(nodeid)
+		log.Printf("[INFO] starting %s.%d sync\n", nodeName, vmid)
 
+		callback := Callback{}
+		instance, err := GetInstance(&callback, &cluster, nodeName, vmid)
 		if err != nil {
-			c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
+			log.Printf("[ERR ] failed to sync %s.%d: %s", nodeName, vmid, err.Error())
+			paas.HTTPWriteJson(w, http.StatusNotFound, map[string]any{"error": err.Error()})
+			callback.Invoke()
 			return
-		} else {
-			instance, err := node.GetInstance(uint(vmid))
-			if err != nil {
-				c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
-				return
-			} else {
-				c.JSON(http.StatusOK, gin.H{"instance": instance})
-				return
-			}
+		}
+		callback.Invoke()
+
+		err = instance.Sync()
+		if err != nil {
+			log.Printf("[ERR ] failed to sync %s.%d: %s", nodeName, vmid, err.Error())
+			paas.HTTPWriteJson(w, http.StatusNotFound, map[string]any{"error": err.Error()})
 		}
 	})
 
-	router.POST("/sync", func(c *gin.Context) {
-		//go func() {
-		start := time.Now()
-		log.Printf("Starting cluster sync\n")
-		cluster.Sync()
-		log.Printf("Synced cluster in %fs\n", time.Since(start).Seconds())
-		//}()
-	})
+	server := paas.LoggingMiddleware(router)
 
-	router.POST("/nodes/:node/sync", func(c *gin.Context) {
-		nodeid := c.Param("node")
-		//go func() {
-		start := time.Now()
-		log.Printf("Starting %s sync\n", nodeid)
-		err := cluster.RebuildHost(nodeid)
-		if err != nil {
-			log.Printf("Failed to sync %s: %s", nodeid, err.Error())
-			return
-		} else {
-			log.Printf("Synced %s in %fs\n", nodeid, time.Since(start).Seconds())
-			return
-		}
-		//}()
-	})
-
-	router.POST("/nodes/:node/instances/:vmid/sync", func(c *gin.Context) {
-		nodeid := c.Param("node")
-		vmid, err := strconv.ParseUint(c.Param("vmid"), 10, 64)
-		if err != nil {
-			c.JSON(http.StatusInternalServerError, gin.H{"error": fmt.Sprintf("%s could not be converted to vmid (uint)", c.Param("instance"))})
-			return
-		}
-
-		//go func() {
-		start := time.Now()
-		log.Printf("Starting %s.%d sync\n", nodeid, vmid)
-
-		node, err := cluster.GetNode(nodeid)
-		if err != nil {
-			log.Printf("Failed to sync %s.%d: %s", nodeid, vmid, err.Error())
-			return
-		}
-
-		instance, err := node.GetInstance(uint(vmid))
-		if err != nil {
-			log.Printf("Failed to sync %s.%d: %s", nodeid, vmid, err.Error())
-			return
-		}
-
-		err = node.RebuildInstance(instance.Type, uint(vmid))
-		if err != nil {
-			log.Printf("Failed to sync %s.%d: %s", nodeid, vmid, err.Error())
-			return
-		} else {
-			log.Printf("Synced %s.%d in %fs\n", nodeid, vmid, time.Since(start).Seconds())
-			return
-		}
-		//}()
-	})
-
-	router.Run("0.0.0.0:" + strconv.Itoa(config.ListenPort))
+	log.Printf("[INFO] starting API listening on 0.0.0.0:%d", config.ListenPort)
+	log.Fatalf("[ERR ] starting gin router: %s", http.ListenAndServe("0.0.0.0:"+strconv.Itoa(config.ListenPort), server))
 }

app/model.go

@@ -1,110 +1,308 @@
 package app
 
 import (
+	"context"
 	"fmt"
 	"log"
+	paas "proxmoxaas-fabric/proxmoxaas-common-lib"
 	"strings"
+	"time"
+
+	"golang.org/x/sync/errgroup"
 )
 
 func (cluster *Cluster) Init(pve ProxmoxClient) {
 	cluster.pve = pve
 }
 
+func GetCluster(callback *Callback, cluster *Cluster) (*Cluster, error) {
+	// obtain read lock on whole cluster tree
+	cluster.lock.RLock()
+	callback.Add(cluster.lock.RUnlock)
+
+	if !cluster.OK {
+		return nil, fmt.Errorf("cluster state is invalid")
+	}
+
+	for _, node := range cluster.Nodes {
+		node.lock.RLock()
+		callback.Add(node.lock.RUnlock)
+		for _, instance := range node.Instances {
+			instance.lock.RLock()
+			callback.Add(instance.lock.RUnlock)
+		}
+	}
+
+	return cluster, nil
+}
+
 func (cluster *Cluster) Sync() error {
-	// aquire lock on cluster, release on return
+	// obtain write lock on whole tree
 	cluster.lock.Lock()
 	defer cluster.lock.Unlock()
+	for _, n := range cluster.Nodes {
+		n.lock.Lock()
+		defer n.lock.Unlock()
+		for _, i := range n.Instances {
+			i.lock.Lock()
+			defer i.lock.Unlock()
+		}
+	}
+
+	err := cluster.Build()
+	if err != nil {
+		cluster.OK = false
+		return err
+	}
+
+	err = cluster.ResolvePoolMembership()
+	if err != nil {
+		cluster.OK = false
+		return err
+	}
+
+	cluster.OK = true
+
+	return nil
+}
+
+func (cluster *Cluster) Build() error {
+	start := time.Now()
 
 	cluster.Nodes = make(map[string]*Node)
 
+	wg, _ := errgroup.WithContext(context.Background())
+
 	// get all nodes
 	nodes, err := cluster.pve.Nodes()
 	if err != nil {
 		return err
 	}
+
 	// for each node:
-	for _, hostName := range nodes {
-		// rebuild node
-		err := cluster.RebuildHost(hostName)
-		if err != nil { // if an error was encountered, continue and log the error
-			log.Print(err.Error())
-			continue
-		}
+	for _, nodeName := range nodes {
+		wg.Go(func() error {
+			// rebuild node
+			node := Node{}
+
+			node.Name = nodeName
+			node.cluster = cluster
+
+			err := node.Build()
+			if err != nil { // if an error was encountered, continue and log the error
+				log.Printf("[ERR ] error encountered while syncing node %s: %s", nodeName, err)
+			}
+
+			cluster.NodesLock.Lock()
+			cluster.Nodes[nodeName] = &node
+			cluster.NodesLock.Unlock()
+
+			return err
+		})
 	}
 
+	err = wg.Wait()
+	if err != nil {
+		cluster.lock.Unlock()
+		return err
+	}
+
+	log.Printf("[INFO] built cluster in %d ms", time.Since(start).Milliseconds())
+
 	return nil
 }
 
-// get a node in the cluster
-func (cluster *Cluster) GetNode(hostName string) (*Node, error) {
-	host_ch := make(chan *Node)
-	err_ch := make(chan error)
+func (cluster *Cluster) ResolvePoolMembership() error {
+	start := time.Now()
 
-	go func() {
-		// aquire cluster lock
-		cluster.lock.Lock()
-		defer cluster.lock.Unlock()
-		// get host
-		host, ok := cluster.Nodes[hostName]
-		if !ok {
-			host_ch <- nil
-			err_ch <- fmt.Errorf("%s not in cluster", hostName)
-		} else {
-			// aquire host lock to wait in case of a concurrent write
-			host.lock.Lock()
-			defer host.lock.Unlock()
-
-			host_ch <- host
-			err_ch <- nil
+	//clear existing pool memberships
+	for _, node := range cluster.Nodes {
+		for _, instance := range node.Instances {
+			instance.Pool = ""
 		}
-	}()
-
-	host := <-host_ch
-	err := <-err_ch
-
-	return host, err
-}
-
-func (cluster *Cluster) RebuildHost(hostName string) error {
-	host, err := cluster.pve.Node(hostName)
-	if err != nil { // host is probably down or otherwise unreachable
-		return fmt.Errorf("error retrieving %s: %s, possibly down?", hostName, err.Error())
 	}
 
-	// aquire lock on host, release on return
-	host.lock.Lock()
-	defer host.lock.Unlock()
+	//resolve pool membership
+	pools, err := cluster.pve.client.Pools(context.Background())
+	if err != nil {
+		return err
+	}
+	for _, pool := range pools {
+		pool, err = cluster.pve.client.Pool(context.Background(), pool.PoolID)
+		if err != nil {
+			return err
+		}
+		for _, member := range pool.Members {
+			if member.Type == "lxc" || member.Type == "qemu" {
+				node, ok := cluster.Nodes[member.Node]
+				if !ok {
+					return fmt.Errorf("Instance %d has no node", member.VMID)
+				}
+				instance, ok := node.Instances[InstanceID(member.VMID)]
+				if !ok {
+					return fmt.Errorf("Instance %d claimed to be in node %s but was not", member.VMID, node.Name)
+				}
+				if instance.Pool != "" { // enforces that an instance cannot be in two different pools
+					return fmt.Errorf("Instance %d is in pools %s and %s which is not supported", member.VMID, instance.Pool, pool.PoolID)
+				}
+				instance.Pool = pool.PoolID
+				log.Printf("[INFO] resolved pool membership for vmid=%d pool=%s", member.VMID, pool.PoolID)
+			}
+		}
+	}
 
-	cluster.Nodes[hostName] = host
+	log.Printf("[INFO] resovled cluster instance pool memberships in %d ms", time.Since(start).Milliseconds())
+
+	return nil
+}
+
+func GetNode(callback *Callback, cluster *Cluster, nodeName string) (*Node, error) {
+	cluster.lock.RLock()
+	callback.Add(cluster.lock.RUnlock)
+
+	if !cluster.OK {
+		return nil, fmt.Errorf("cluster state is invalid")
+	}
+
+	// get node
+	node, ok := cluster.Nodes[nodeName]
+	if !ok {
+		return nil, fmt.Errorf("%s not in cluster", nodeName)
+	}
+
+	node.lock.RLock()
+	callback.Add(node.lock.RUnlock)
+	for _, instance := range node.Instances {
+		instance.lock.RLock()
+		callback.Add(instance.lock.RUnlock)
+	}
+
+	return node, nil
+}
+
+func (node *Node) Sync() error {
+	cluster := node.cluster
+
+	// obtain write lock on this node subtree, and obtain write lock all instances for ResolvePoolMembership, obtain read lock on everything else
+	cluster.lock.Lock() // todo relax
+	defer cluster.lock.Unlock()
+	for _, n := range cluster.Nodes {
+		if n != node { // if other node, read lock
+			n.lock.RLock()
+			defer n.lock.RUnlock()
+		} else { // if this node, write lock
+			n.lock.Lock()
+			defer n.lock.Unlock()
+		}
+		for _, i := range n.Instances { // need write lock on all instances
+			i.lock.Lock()
+			defer i.lock.Unlock()
+		}
+	}
+
+	err := node.Build()
+	if err != nil {
+		cluster.OK = false
+		return err
+	}
+
+	err = cluster.ResolvePoolMembership()
+	if err != nil {
+		cluster.OK = false
+		return err
+	}
+
+	cluster.OK = true
+	return nil
+}
+
+func (node *Node) Build() error {
+	start := time.Now()
+
+	nodeName := node.Name
+	cluster := node.cluster
+
+	err := cluster.pve.Node(node, nodeName)
+	if err != nil && cluster.Nodes[nodeName] == nil { // node is unreachable and did not exist previously
+		// return an error because we requested to sync a node that was not already in the cluster
+		return fmt.Errorf("error retrieving %s: %s", nodeName, err.Error())
+	}
+
+	wg, _ := errgroup.WithContext(context.Background())
+
+	if err != nil && cluster.Nodes[nodeName] != nil { // node is unreachable and did exist previously
+		// assume the node is down or gone and delete from cluster
+		delete(cluster.Nodes, nodeName)
+		return nil
+	}
 
 	// get node's VMs
-	vms, err := host.VirtualMachines()
+	vms, err := node.VirtualMachines()
 	if err != nil {
 		return err
 
 	}
 	for _, vmid := range vms {
-		err := host.RebuildInstance(VM, vmid)
-		if err != nil { // if an error was encountered, continue and log the error
-			log.Print(err.Error())
-			continue
-		}
+		wg.Go(func() error {
+
+			instanceID := InstanceID(paas.SafeUint64(vmid))
+			instance := Instance{}
+			instance.lock.Lock()
+
+			instance.VMID = instanceID
+			instance.Type = VM
+			instance.node = node
+
+			err := instance.Build()
+			if err != nil { // if an error was encountered, continue and log the error
+				log.Printf("[ERR ] error encountered while syncing vm %s.%d: %s", nodeName, vmid, err)
+			}
+
+			node.Instances[instanceID] = &instance
+
+			instance.lock.Unlock()
+
+			return nil
+		})
 	}
 
 	// get node's CTs
-	cts, err := host.Containers()
+	cts, err := node.Containers()
 	if err != nil {
 		return err
 	}
 	for _, vmid := range cts {
-		err := host.RebuildInstance(CT, vmid)
-		if err != nil {
-			return err
-		}
+		wg.Go(func() error {
+			instanceID := InstanceID(paas.SafeUint64(vmid))
+			instance := Instance{}
+			instance.lock.Lock()
+
+			instance.VMID = instanceID
+			instance.Type = CT
+			instance.node = node
+
+			err := instance.Build()
+			if err != nil { // if an error was encountered, continue and log the error
+				log.Printf("[ERR ] error encountered while syncing ct %s.%d: %s", nodeName, vmid, err)
+			}
+
+			node.InstancesLock.Lock()
+			node.Instances[instanceID] = &instance
+			node.InstancesLock.Unlock()
+
+			instance.lock.Unlock()
+
+			return nil
+		})
+	}
+
+	err = wg.Wait()
+	if err != nil {
+		return err
 	}
 
 	// check node device reserved by iterating over each function, we will assume that a single reserved function means the device is also reserved
-	for _, device := range host.Devices {
+	for _, device := range node.Devices {
 		reserved := false
 		for _, function := range device.Functions {
 			reserved = reserved || function.Reserved
@@ -112,96 +310,172 @@ func (cluster *Cluster) RebuildHost(hostName string) error {
 		device.Reserved = reserved
 	}
 
+	node.cluster = cluster
+
+	log.Printf("[INFO] built node %s in %d ms", node.Name, time.Since(start).Milliseconds())
+
 	return nil
 }
 
-func (host *Node) GetInstance(vmid uint) (*Instance, error) {
-	instance_ch := make(chan *Instance)
-	err_ch := make(chan error)
+func GetInstance(callback *Callback, cluster *Cluster, nodeName string, vmid uint64) (*Instance, error) {
+	// obtain read lock on whole tree, but do not hold cluster and node read lock indefinitely
+	cluster.lock.RLock()
+	callback.Add(cluster.lock.RUnlock)
 
-	go func() {
-		// aquire host lock
-		host.lock.Lock()
-		defer host.lock.Unlock()
-		// get instance
-		instance, ok := host.Instances[InstanceID(vmid)]
-		if !ok {
-			instance_ch <- nil
-			err_ch <- fmt.Errorf("vmid %d not in host %s", vmid, host.Name)
-		} else {
-			// aquire instance lock to wait in case of a concurrent write
-			instance.lock.Lock()
-			defer instance.lock.Unlock()
+	if !cluster.OK {
+		return nil, fmt.Errorf("cluster state is invalid")
+	}
 
-			instance_ch <- instance
-			err_ch <- nil
-		}
-	}()
+	// get node
+	node, ok := cluster.Nodes[nodeName]
+	if !ok {
+		return nil, fmt.Errorf("%s not in cluster", nodeName)
+	}
+	node.lock.RLock()
+	callback.Add(node.lock.RUnlock)
 
-	instance := <-instance_ch
-	err := <-err_ch
-	return instance, err
+	// get instance
+	instance, ok := node.Instances[InstanceID(vmid)]
+	if !ok {
+		return nil, fmt.Errorf("vmid %d not in node %s", vmid, node.Name)
+	} else {
+		instance.lock.RLock()
+		callback.Add(instance.lock.RUnlock)
+		return instance, nil
+	}
 }
 
-func (host *Node) RebuildInstance(instancetype InstanceType, vmid uint) error {
-	var instance *Instance
-	if instancetype == VM {
-		var err error
-		instance, err = host.VirtualMachine(vmid)
-		if err != nil {
-			return fmt.Errorf("error retrieving %d: %s, possibly down?", vmid, err.Error())
-		}
-	} else if instancetype == CT {
-		var err error
-		instance, err = host.Container(vmid)
-		if err != nil {
-			return fmt.Errorf("error retrieving %d: %s, possibly down?", vmid, err.Error())
+func (instance *Instance) Sync() error {
+	cluster := instance.node.cluster
+
+	// obtain write lock on this instance subtree, and obtain write lock all instances for ResolvePoolMembership, obtain read lock on everything else
+	cluster.lock.Lock() // todo relax
+	defer cluster.lock.Unlock()
+	for _, n := range cluster.Nodes {
+		n.lock.RLock()
+		defer n.lock.RUnlock()
+		for _, i := range n.Instances { // need write lock on all instances
+			i.lock.Lock()
+			defer i.lock.Unlock()
 		}
+	}
+
+	err := instance.Build()
+	if err != nil {
+		cluster.OK = false
+		return err
+	}
+
+	err = cluster.ResolvePoolMembership()
+	if err != nil {
+		cluster.OK = false
+		return err
+	}
+
+	cluster.OK = true
+	return nil
+}
+
+func (instance *Instance) Build() error {
+	start := time.Now()
+
+	vmid := instance.VMID
+	instancetype := instance.Type
+	node := instance.node
+	var err error
+	switch instancetype {
+	case VM:
+		err = node.VirtualMachine(instance, vmid)
+	case CT:
+		err = node.Container(instance, vmid)
 
 	}
 
-	// aquire lock on instance, release on return
-	instance.lock.Lock()
-	defer instance.lock.Unlock()
+	if err != nil && node.Instances[vmid] == nil { // instance is unreachable and did not exist previously
+		// return an error because we requested to sync an instance that was not already in the cluster
+		return fmt.Errorf("error retrieving %s.%d: %s", node.Name, vmid, err.Error())
+	}
 
-	host.Instances[InstanceID(vmid)] = instance
+	wg, _ := errgroup.WithContext(context.Background())
+
+	if err != nil && node.Instances[vmid] != nil { // node is unreachable and did exist previously
+		// assume the instance is gone and delete from cluster
+		log.Printf("[ERR ] error retrieving %s.%d: %s", node.Name, vmid, err)
+		delete(node.Instances, vmid)
+		return nil
+	}
 
 	for volid := range instance.configDisks {
-		instance.RebuildVolume(host, volid)
+		wg.Go(func() error {
+			err := instance.BuildVolume(node, volid)
+			if err != nil {
+				log.Printf("[ERR ] error rebuilding volume %s: %s", volid, err)
+			}
+			return err
+		})
 	}
 
 	for netid := range instance.configNets {
-		instance.RebuildNet(netid)
+		wg.Go(func() error {
+			err := instance.BuildNet(node, netid)
+			if err != nil {
+				log.Printf("[ERR ] error rebuilding net %s: %s", netid, err)
+				return err
+			}
+			return err
+		})
 	}
 
 	for deviceid := range instance.configHostPCIs {
-		instance.RebuildDevice(host, deviceid)
+		wg.Go(func() error {
+			err := instance.BuildDevice(node, deviceid)
+			if err != nil {
+				log.Printf("[ERR ] error rebuilding pci %s: %s", deviceid, err)
+			}
+			return err
+		})
 	}
 
-	if instance.Type == VM {
-		instance.RebuildBoot()
-	}
-
-	return nil
-}
-
-func (instance *Instance) RebuildVolume(host *Node, volid string) error {
-	volumeDataString := instance.configDisks[volid]
-
-	volume, err := GetVolumeInfo(host, volumeDataString)
+	err = wg.Wait()
 	if err != nil {
 		return err
 	}
 
-	voltype := AnyPrefixes(volid, VolumeTypes)
-	volume.Type = voltype
-	volume.Volume_ID = VolumeID(volid)
-	instance.Volumes[VolumeID(volid)] = volume
+	if instance.Type == VM {
+		err := instance.BuildBoot(node)
+		if err != nil {
+			log.Printf("[ERR ] error rebuilding boot: %s", err)
+			return err
+		}
+	}
+
+	instance.node = node
+
+	log.Printf("[INFO] built instance %s.%d in %d ms", instance.node.Name, instance.VMID, time.Since(start).Milliseconds())
 
 	return nil
 }
 
-func (instance *Instance) RebuildNet(netid string) error {
+func (instance *Instance) BuildVolume(node *Node, volid string) error {
+	volumeDataString := instance.configDisks[volid]
+
+	volume, err := GetVolumeInfo(node, volumeDataString)
+	if err != nil {
+		return err
+	}
+
+	voltype := AnyPrefixes(volid, paas.VolumeTypes)
+	volume.Type = voltype
+	volume.Volume_ID = VolumeID(volid)
+
+	instance.VolumesLock.Lock()
+	instance.Volumes[VolumeID(volid)] = volume
+	instance.VolumesLock.Unlock()
+
+	return nil
+}
+
+func (instance *Instance) BuildNet(node *Node, netid string) error {
 	net := instance.configNets[netid]
 
 	netinfo, err := GetNetInfo(net)
@@ -210,22 +484,25 @@ func (instance *Instance) RebuildNet(netid string) error {
 		return nil
 	}
 
+	instance.NetsLock.Lock()
 	instance.Nets[NetID(netid)] = netinfo
+	instance.NetsLock.Unlock()
 
 	return nil
 }
 
-func (instance *Instance) RebuildDevice(host *Node, deviceid string) error {
+func (instance *Instance) BuildDevice(node *Node, deviceid string) error {
 	instanceDevice, ok := instance.configHostPCIs[deviceid]
 	if !ok { // if device does not exist
-		return fmt.Errorf("%s not found in devices", deviceid)
+		log.Printf("[WARN] %s not found in devices on node %s", deviceid, node.Name)
+		return nil
 	}
 
 	hostDeviceBusID := DeviceID(strings.Split(instanceDevice, ",")[0])
 	instanceDeviceBusID := DeviceID(deviceid)
 
 	if DeviceBusIDIsSuperDevice(hostDeviceBusID) {
-		instance.Devices[DeviceID(instanceDeviceBusID)] = host.Devices[DeviceBus(hostDeviceBusID)]
+		instance.Devices[DeviceID(instanceDeviceBusID)] = node.Devices[DeviceBus(hostDeviceBusID)]
 		for _, function := range instance.Devices[DeviceID(instanceDeviceBusID)].Functions {
 			function.Reserved = true
 		}
@@ -233,13 +510,14 @@ func (instance *Instance) RebuildDevice(host *Node, deviceid string) error {
 		// sub function assignment not supported yet
 	}
 
+	instance.DevicesLock.Lock()
 	instance.Devices[DeviceID(instanceDeviceBusID)].Device_ID = DeviceID(deviceid)
-	instance.Devices[DeviceID(instanceDeviceBusID)].Value = instanceDevice
+	instance.DevicesLock.Unlock()
 
 	return nil
 }
 
-func (instance *Instance) RebuildBoot() {
+func (instance *Instance) BuildBoot(node *Node) error {
 	instance.Boot = BootOrder{}
 
 	eligibleBoot := map[string]bool{}
@@ -265,7 +543,7 @@ func (instance *Instance) RebuildBoot() {
 				instance.Boot.Enabled = append(instance.Boot.Enabled, val)
 				delete(eligibleBoot, bootTarget)
 			} else { // item is not eligible for boot but is included in the boot order
-				log.Printf("Encountered enabled but non-eligible boot target %s in instance %s\n", bootTarget, instance.Name)
+				log.Printf("[WARN] encountered enabled but non-eligible boot target %s in instance %s\n", bootTarget, instance.Name)
 				delete(eligibleBoot, bootTarget)
 			}
 		}
@@ -277,7 +555,9 @@ func (instance *Instance) RebuildBoot() {
 		} else if val, ok := instance.Nets[NetID(bootTarget)]; ok && isEligible { // if the item is eligible and is in nets
 			instance.Boot.Disabled = append(instance.Boot.Disabled, val)
 		} else { // item is not eligible and is not already in the boot order, skip adding to model
-			log.Printf("Encountered disabled and non-eligible boot target %s in instance %s\n", bootTarget, instance.Name)
+			log.Printf("[WARN] encountered disabled and non-eligible boot target %s in instance %s\n", bootTarget, instance.Name)
 		}
 	}
+
+	return nil
 }

app/proxmox.go

@@ -4,11 +4,14 @@ import (
 	"context"
 	"crypto/tls"
 	"fmt"
+	"maps"
 	"net/http"
+	paas "proxmoxaas-fabric/proxmoxaas-common-lib"
 	"strconv"
 	"strings"
 
 	"github.com/luthermonson/go-proxmox"
+	"golang.org/x/sync/errgroup"
 )
 
 type ProxmoxClient struct {
@@ -32,9 +35,7 @@ type PVEProctype struct {
 func NewClient(url string, token string, secret string) ProxmoxClient {
 	HTTPClient := http.Client{
 		Transport: &http.Transport{
-			TLSClientConfig: &tls.Config{
-				InsecureSkipVerify: true,
-			},
+			TLSClientConfig: &tls.Config{},
 		},
 	}
 
@@ -71,22 +72,25 @@ func (pve ProxmoxClient) Nodes() ([]string, error) {
 }
 
 // Gets a Node's resources but does not recursively expand instances
-func (pve ProxmoxClient) Node(nodeName string) (*Node, error) {
-	host := Node{}
+func (pve ProxmoxClient) Node(host *Node, nodeName string) error {
+	//host := Node{}
 	host.Devices = make(map[DeviceBus]*Device)
 	host.Instances = make(map[InstanceID]*Instance)
+	host.storage = make(map[string][]*proxmox.StorageContent)
 
+	// get pve node
 	node, err := pve.client.Node(context.Background(), nodeName)
 	if err != nil {
-		return &host, err
+		return err
 	}
 
+	// get pve node devices
 	devices := []PVEDevice{}
 	err = pve.client.Get(context.Background(), fmt.Sprintf("/nodes/%s/hardware/pci", nodeName), &devices)
 	if err != nil {
-		return &host, err
+		return err
 	}
-
+	// populate host devices from pve node devices
 	for _, device := range devices {
 		x := strings.Split(device.ID, ".")
 		if len(x) != 2 { // this should always be true, but skip if not
@@ -110,22 +114,51 @@ func (pve ProxmoxClient) Node(nodeName string) (*Node, error) {
 		}
 	}
 
+	// get pve node proctypes
 	proctypes := []PVEProctype{}
 	err = pve.client.Get(context.Background(), fmt.Sprintf("/nodes/%s/capabilities/qemu/cpu", nodeName), &proctypes)
 	if err != nil {
-		return &host, err
+		return err
 	}
+	// populate host proctypes from pve node proctypes
 	for _, proctype := range proctypes {
 		host.Proctypes = append(host.Proctypes, proctype.Name)
 	}
 
+	// get all pve node storages
+	wg, _ := errgroup.WithContext(context.Background())
+	storages, err := node.Storages(context.Background())
+	if err != nil {
+		return err
+	}
+	// populate host storage content from pve node storages
+	for _, storage := range storages {
+		wg.Go(func() error {
+			if storage.Enabled == 1 && storage.Active == 1 {
+				content, err := storage.GetContent(context.Background())
+				if err != nil {
+					return err
+				}
+				host.storageLock.Lock()
+				host.storage[storage.Name] = content
+				host.storageLock.Unlock()
+			}
+			return nil
+		})
+	}
+	err = wg.Wait()
+	if err != nil {
+		return err
+	}
+
+	// set host basic values
 	host.Name = node.Name
-	host.Cores = uint64(node.CPUInfo.CPUs)
-	host.Memory = uint64(node.Memory.Total)
-	host.Swap = uint64(node.Swap.Total)
+	host.Cores = paas.SafeUint64(node.CPUInfo.CPUs)
+	host.Memory = node.Memory.Total
+	host.Swap = node.Swap.Total
 	host.pvenode = node
 
-	return &host, err
+	return err
 }
 
 // Get all VM IDs on specified host
@@ -142,16 +175,15 @@ func (host *Node) VirtualMachines() ([]uint, error) {
 }
 
 // Get a VM's CPU, Memory but does not recursively link Devices, Disks, Drives, Nets
-func (host *Node) VirtualMachine(VMID uint) (*Instance, error) {
-	instance := Instance{}
+func (host *Node) VirtualMachine(instance *Instance, VMID InstanceID) error {
 	vm, err := host.pvenode.VirtualMachine(context.Background(), int(VMID))
 	if err != nil {
-		return &instance, err
+		return err
 	}
 
 	config := vm.VirtualMachineConfig
-	instance.configHostPCIs = config.MergeHostPCIs()
-	instance.configNets = config.MergeNets()
+	instance.configHostPCIs = config.HostPCIs
+	instance.configNets = config.Nets
 	instance.configDisks = MergeVMDisksAndUnused(config)
 	instance.configBoot = config.Boot
 
@@ -160,20 +192,18 @@ func (host *Node) VirtualMachine(VMID uint) (*Instance, error) {
 
 	instance.Name = vm.Name
 	instance.Proctype = vm.VirtualMachineConfig.CPU
-	instance.Cores = uint64(vm.VirtualMachineConfig.Cores)
-	instance.Memory = uint64(vm.VirtualMachineConfig.Memory) * MiB
+	instance.Cores = paas.SafeUint64(*vm.VirtualMachineConfig.Cores)
+	instance.Memory = paas.SafeUint64(int(vm.VirtualMachineConfig.Memory)) * paas.MiB
 	instance.Volumes = make(map[VolumeID]*Volume)
 	instance.Nets = make(map[NetID]*Net)
 	instance.Devices = make(map[DeviceID]*Device)
 
-	return &instance, nil
+	return nil
 }
 
 func MergeVMDisksAndUnused(vmc *proxmox.VirtualMachineConfig) map[string]string {
 	mergedDisks := vmc.MergeDisks()
-	for k, v := range vmc.MergeUnuseds() {
-		mergedDisks[k] = v
-	}
+	maps.Copy(mergedDisks, vmc.Unuseds)
 	return mergedDisks
 }
 
@@ -191,39 +221,34 @@ func (host *Node) Containers() ([]uint, error) {
 }
 
 // Get a CT's CPU, Memory, Swap but does not recursively link Devices, Disks, Drives, Nets
-func (host *Node) Container(VMID uint) (*Instance, error) {
-	instance := Instance{}
+func (host *Node) Container(instance *Instance, VMID InstanceID) error {
 	ct, err := host.pvenode.Container(context.Background(), int(VMID))
 	if err != nil {
-		return &instance, err
+		return err
 	}
 
 	config := ct.ContainerConfig
 	instance.configHostPCIs = make(map[string]string)
-	instance.configNets = config.MergeNets()
+	instance.configNets = config.Nets
 	instance.configDisks = MergeCTDisksAndUnused(config)
 
 	instance.pveconfig = config
 	instance.Type = CT
 
 	instance.Name = ct.Name
-	instance.Cores = uint64(ct.ContainerConfig.Cores)
-	instance.Memory = uint64(ct.ContainerConfig.Memory) * MiB
-	instance.Swap = uint64(ct.ContainerConfig.Swap) * MiB
+	instance.Cores = paas.SafeUint64(ct.ContainerConfig.Cores)
+	instance.Memory = paas.SafeUint64(*ct.ContainerConfig.Memory) * paas.MiB
+	instance.Swap = paas.SafeUint64(*ct.ContainerConfig.Swap) * paas.MiB
 	instance.Volumes = make(map[VolumeID]*Volume)
 	instance.Nets = make(map[NetID]*Net)
 
-	return &instance, nil
+	return nil
 }
 
 func MergeCTDisksAndUnused(cc *proxmox.ContainerConfig) map[string]string {
 	mergedDisks := make(map[string]string)
-	for k, v := range cc.MergeUnuseds() {
-		mergedDisks[k] = v
-	}
-	for k, v := range cc.MergeMps() {
-		mergedDisks[k] = v
-	}
+	maps.Copy(mergedDisks, cc.Unuseds)
+	maps.Copy(mergedDisks, cc.Mps)
 	mergedDisks["rootfs"] = cc.RootFS
 	return mergedDisks
 }
@@ -236,21 +261,19 @@ func GetVolumeInfo(host *Node, volume string) (*Volume, error) {
 	volumeFile := volumeObj[""]
 	volumeStorage := strings.Split(volumeFile, ":")[0]
 
-	storage, err := host.pvenode.Storage(context.Background(), volumeStorage)
-	if err != nil {
-		return &volumeData, nil
+	host.storageLock.Lock()
+	storage, ok := host.storage[volumeStorage]
+	host.storageLock.Unlock()
+
+	if !ok {
+		return &volumeData, fmt.Errorf("volume %s claims to be in storage %s but storage was not found", volume, volumeStorage)
 	}
 
-	content, err := storage.GetContent(context.Background())
-	if err != nil {
-		return &volumeData, nil
-	}
-
-	for _, c := range content {
+	for _, c := range storage {
 		if c.Volid == volumeFile {
 			volumeData.Storage = volumeStorage
 			volumeData.Format = c.Format
-			volumeData.Size = uint64(c.Size)
+			volumeData.Size = c.Size
 			volumeData.File = volumeFile
 			volumeData.MP = volumeObj["mp"]
 		}

app/types.go

@@ -1,105 +1,81 @@
 package app
 
 import (
+	paas "proxmoxaas-fabric/proxmoxaas-common-lib"
 	"sync"
 
 	"github.com/luthermonson/go-proxmox"
 )
 
+// uses and aliases common resource types from proxmoxaas-common-lib
+// except for Cluster, Node, and Instance which require mutex locks and additional fields
+
+// add mutex and pve client
+// override Nodes map to new custom Node type
 type Cluster struct {
-	lock  sync.Mutex
-	pve   ProxmoxClient
-	Nodes map[string]*Node
+	paas.Cluster
+	lock      sync.RWMutex
+	pve       ProxmoxClient
+	NodesLock sync.Mutex       // lock for Nodes map
+	Nodes     map[string]*Node `json:"nodes"`
+	OK        bool
 }
 
+// add mutex and pve api Node object
+// override Instances map to new custom Instance type
 type Node struct {
-	lock      sync.Mutex
-	Name      string                   `json:"name"`
-	Cores     uint64                   `json:"cores"`
-	Memory    uint64                   `json:"memory"`
-	Swap      uint64                   `json:"swap"`
-	Devices   map[DeviceBus]*Device    `json:"devices"`
-	Instances map[InstanceID]*Instance `json:"instances"`
-	Proctypes []string                 `json:"cpus"`
-	pvenode   *proxmox.Node
+	paas.Node
+	lock          sync.RWMutex
+	InstancesLock sync.Mutex               // lock for Instances map
+	Instances     map[InstanceID]*Instance `json:"instances"`
+	pvenode       *proxmox.Node
+	storageLock   sync.Mutex
+	storage       map[string][]*proxmox.StorageContent
+	cluster       *Cluster
 }
 
-type InstanceID uint64
-type InstanceType string
+type InstanceID = paas.InstanceID
+type InstanceType = paas.InstanceType
 
-const (
-	VM InstanceType = "VM"
-	CT InstanceType = "CT"
-)
+const VM InstanceType = paas.VM
+const CT InstanceType = paas.CT
 
+// add mutex and various config objects
 type Instance struct {
-	lock           sync.Mutex
-	Type           InstanceType         `json:"type"`
-	Name           string               `json:"name"`
-	Proctype       string               `json:"cpu"`
-	Cores          uint64               `json:"cores"`
-	Memory         uint64               `json:"memory"`
-	Swap           uint64               `json:"swap"`
-	Volumes        map[VolumeID]*Volume `json:"volumes"`
-	Nets           map[NetID]*Net       `json:"nets"`
-	Devices        map[DeviceID]*Device `json:"devices"`
-	Boot           BootOrder            `json:"boot"`
+	paas.Instance
+	lock           sync.RWMutex
+	VolumesLock    sync.Mutex // lock for Volumes map
+	NetsLock       sync.Mutex // lock for Nets map
+	DevicesLock    sync.Mutex // lock for Devices map
 	pveconfig      any
 	configDisks    map[string]string
 	configNets     map[string]string
 	configHostPCIs map[string]string
 	configBoot     string
+	node           *Node
 }
 
-var VolumeTypes = []string{
-	"sata",
-	"scsi",
-	"ide",
-	"rootfs",
-	"mp",
-	"unused",
+type VolumeID = paas.VolumeID
+type Volume = paas.Volume
+type NetID = paas.NetID
+type Net = paas.Net
+type DeviceID = paas.DeviceID
+type DeviceBus = paas.DeviceBus
+type Device = paas.Device
+type FunctionID = paas.FunctionID
+type Function = paas.Function
+type BootOrder = paas.BootOrder
+
+type Callback struct {
+	f []func()
 }
 
-type VolumeID string
-type Volume struct {
-	Volume_ID VolumeID `json:"volume_id"`
-	Type      string   `json:"type"`
-	Storage   string   `json:"storage"`
-	Format    string   `json:"format"`
-	Size      uint64   `json:"size"`
-	File      string   `json:"file"`
-	MP        string   `json:"mp"`
+func (c *Callback) Add(nf func()) {
+	c.f = append(c.f, nf)
 }
 
-type NetID string
-type Net struct {
-	Net_ID NetID  `json:"net_id"`
-	Value  string `json:"value"`
-	Rate   uint64 `json:"rate"`
-	VLAN   uint64 `json:"vlan"`
-}
-
-type DeviceID string
-type DeviceBus string
-type Device struct {
-	Device_ID   DeviceID                 `json:"device_id"`
-	Device_Bus  DeviceBus                `json:"device_bus"`
-	Device_Name string                   `json:"device_name"`
-	Vendor_Name string                   `json:"vendor_name"`
-	Functions   map[FunctionID]*Function `json:"functions"`
-	Reserved    bool                     `json:"reserved"`
-	Value       string
-}
-
-type FunctionID string
-type Function struct {
-	Function_ID   FunctionID `json:"function_id"`
-	Function_Name string     `json:"subsystem_device_name"`
-	Vendor_Name   string     `json:"subsystem_vendor_name"`
-	Reserved      bool       `json:"reserved"`
-}
-
-type BootOrder struct {
-	Enabled  []any `json:"enabled"`
-	Disabled []any `json:"disabled"`
+func (c *Callback) Invoke() {
+	for _, f := range c.f {
+		f()
+	}
 }

app/utils.go

@@ -7,15 +7,13 @@ import (
 	"strings"
 )
 
-const MiB = 1024 * 1024
-
 type Config struct {
 	ListenPort int `json:"listenPort"`
 	PVE        struct {
 		URL   string `json:"url"`
 		Token struct {
-			USER   string `json:"user"`
-			REALM  string `json:"realm"`
+			User   string `json:"user"`
+			Realm  string `json:"realm"`
 			ID     string `json:"id"`
 			Secret string `json:"uuid"`
 		}
@@ -24,15 +22,23 @@ type Config struct {
 }
 
 func GetConfig(configPath string) Config {
-	content, err := os.ReadFile(configPath)
+	root, err := os.OpenRoot(".")
+	if err != nil {
+		log.Fatal("Error when opening root dir: ", err)
+	}
+	defer root.Close()
+
+	content, err := root.ReadFile(configPath)
 	if err != nil {
 		log.Fatal("Error when opening config file: ", err)
 	}
+
 	var config Config
 	err = json.Unmarshal(content, &config)
 	if err != nil {
 		log.Fatal("Error during parsing config file: ", err)
 	}
+
 	return config
 }
 

configs/template.config.json

@@ -1,7 +1,7 @@
 {
-    "listenPort": 80,
+    "listenPort": 8082,
     "pve": {
-        "url": "http://<proxmox host>/api2/json",
+        "url": "https://<proxmox host>/api2/json",
         "token": {
             "user": "proxmoxaas-api",
             "realm": "pam",

go.mod

@@ -1,49 +1,27 @@
 module proxmoxaas-fabric
 
-go 1.24.0
+go 1.27.3
 
 require (
-	github.com/gin-gonic/gin v1.10.1
-	github.com/luthermonson/go-proxmox v0.2.2
+	github.com/luthermonson/go-proxmox v0.8.2
+	golang.org/x/sync v0.24.0
 )
 
 require (
+	github.com/anchore/go-lzo v0.1.0 // indirect
 	github.com/buger/goterm v1.0.4 // indirect
-	github.com/bytedance/gopkg v0.1.3 // indirect
-	github.com/bytedance/sonic v1.14.1 // indirect
-	github.com/bytedance/sonic/loader v0.3.0 // indirect
-	github.com/cloudwego/base64x v0.1.6 // indirect
-	github.com/diskfs/go-diskfs v1.7.0 // indirect
+	github.com/diskfs/go-diskfs v1.9.4 // indirect
 	github.com/djherbis/times v1.6.0 // indirect
-	github.com/elliotwutingfeng/asciiset v0.0.0-20250812055617-fb43ac3ba420 // indirect
-	github.com/gabriel-vasile/mimetype v1.4.10 // indirect
-	github.com/gin-contrib/sse v1.1.0 // indirect
-	github.com/go-playground/locales v0.14.1 // indirect
-	github.com/go-playground/universal-translator v0.18.1 // indirect
-	github.com/go-playground/validator/v10 v10.27.0 // indirect
-	github.com/goccy/go-json v0.10.5 // indirect
+	github.com/elliotwutingfeng/asciiset v0.0.0-20260129054604-cfde2086bc57 // indirect
 	github.com/google/uuid v1.6.0 // indirect
 	github.com/gorilla/websocket v1.5.3 // indirect
 	github.com/jinzhu/copier v0.4.0 // indirect
-	github.com/json-iterator/go v1.1.12 // indirect
-	github.com/klauspost/compress v1.18.0 // indirect
-	github.com/klauspost/cpuid/v2 v2.3.0 // indirect
-	github.com/leodido/go-urn v1.4.0 // indirect
-	github.com/magefile/mage v1.15.0 // indirect
-	github.com/mattn/go-isatty v0.0.20 // indirect
-	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
-	github.com/modern-go/reflect2 v1.0.2 // indirect
-	github.com/pelletier/go-toml/v2 v2.2.4 // indirect
-	github.com/pierrec/lz4/v4 v4.1.22 // indirect
+	github.com/klauspost/compress v1.18.5 // indirect
+	github.com/magefile/mage v1.17.2 // indirect
+	github.com/pierrec/lz4/v4 v4.1.26 // indirect
 	github.com/pkg/xattr v0.4.12 // indirect
-	github.com/twitchyliquid64/golang-asm v0.15.1 // indirect
-	github.com/ugorji/go/codec v1.3.0 // indirect
-	github.com/ulikunitz/xz v0.5.12 // indirect
-	golang.org/x/arch v0.20.0 // indirect
-	golang.org/x/crypto v0.41.0 // indirect
-	golang.org/x/net v0.43.0 // indirect
-	golang.org/x/sys v0.35.0 // indirect
-	golang.org/x/text v0.28.0 // indirect
-	google.golang.org/protobuf v1.36.8 // indirect
-	gopkg.in/yaml.v3 v3.0.1 // indirect
+	github.com/sirupsen/logrus v1.9.4 // indirect
+	github.com/stretchr/testify v1.12.1 // indirect
+	github.com/ulikunitz/xz v0.5.15 // indirect
+	golang.org/x/sys v0.49.0 // indirect
 )