alu/cse110-fa22-group29
1
0
Fork 0
mirror of https://github.com/cse110-fa22-group29/cse110-fa22-group29.git synced 2026-08-28 13:18:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
524 Commits 4 Branches 1 Tag
4ce4f2b2e276a0097991ab45782871a9718854a2
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Arthur Lu 4ce4f2b2e2 fix js-doc missing command 2022-12-03 20:49:16 +00:00
Arthur LuandGitHub e9d33edf00 Merge pull request #90 from cse110-fa22-group29/sprint-3 
Sprint 3
 2022-12-03 12:39:42 -08:00
Arthur Lu a722d755fd fix prettier action 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-03 02:16:27 +00:00
Arthur Lu 793e7891b3 prettier style fixes 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-03 02:02:52 +00:00
Arthur Lu dbbd14399e fix updateReviewToStorage bug with capitalized tag handling, 
remove unnecessary overflow-wrap in ReviewCard.js

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-03 00:14:49 +00:00
Arthur Lu 89dfe3293d fix html linting issue (indentation) 2022-12-02 04:05:24 +00:00
Arthur Lu 32dbb37034 remove typo sw asset 2022-12-02 03:24:08 +00:00
Arthur Lu 396bbf06d2 fix css linting issue 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-02 01:23:40 +00:00
Arthur Lu 1f79340896 remove extra prettier workflow file 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-02 01:18:48 +00:00
Arthur Lu ab7d3b1abd fix missing brancket issue in package.json 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-02 01:16:47 +00:00
Arthur LuandGitHub f863f35de7 Merge branch 'main' into sprint-3 2022-12-01 17:06:37 -08:00
Arthur Lu b07c99f805 fix css linting 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-01 17:02:09 -08:00
Arthur Lu 82aba63baf fix styling issue, 
fix bug in service worker and search URI

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-01 17:01:05 -08:00
Arthur Lu 8924540757 fix service worker inital cache items 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-01 16:48:15 -08:00
Arthur Lu cf7b0da5ad fix tests to match modified localStorage layout 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-01 16:25:15 -08:00
Arthur Lu 1a1f5d8e1f finalize ADR 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-01 22:35:48 +00:00
Arthur Lu 730f904a58 fix style 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-12-01 22:32:50 +00:00
Arthur Lu 7cb90e23c0 add comments and docs to sw.js, 
add service worker ADR
 2022-12-01 08:37:49 +00:00
Arthur Lu 1ed46b8ade implement fix for strange first load cache behavior 2022-12-01 08:09:22 +00:00
Arthur Lu d95f0036ac clean up some styling 2022-12-01 07:36:19 +00:00
Arthur Lu eb3133c676 fix ReviewCard.js element id issue 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-30 17:02:42 -08:00
Arthur Lu 11b152fec9 Merge branch 'filter-sort' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into filter-sort 2022-11-30 16:36:23 -08:00
Arthur Lu 64d57ffd90 fix review details html id consistency, 
fix appTestHelpers with proper element selection

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-30 16:36:21 -08:00
Arthur Lu 3580941207 Add functional service worker caching towards local first functionality, 
fix favicon link issue in ReviewDetails.html
Co-authored-by: rheabhutada02 <rheabhutada02@users.noreply.github.com>

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-30 16:18:18 -08:00
Arthur Lu fa7b8dc7f5 add text break to Form.css 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-30 14:58:34 -08:00
Arthur Lu 5943a5c8ef update tests to match new tag and sorting helper prototypes, 
remove getTopReviewsFromStorage and getReviewsByTag from localStorage and main

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-30 14:49:41 -08:00
Arthur Lu 529f24f306 update phase 2 with future ci features 2022-11-29 22:51:03 +00:00
Arthur Lu c1fd10c268 update cicd phase 2 status 2022-11-29 22:46:16 +00:00
Arthur Lu e74b3f5597 add prettier requirements and commands, 
add prettier ADR,
add prettier action
 2022-11-29 22:38:22 +00:00
Arthur Lu 603fb849f3 add explanation of JSDoc usage to ADR 2022-11-29 22:23:24 +00:00
Arthur Lu dcee487737 add JSDoc ADR, 
add JSDoc to publish action
 2022-11-29 22:18:32 +00:00
Arthur Lu 929de8c98b fix js-doc command 2022-11-29 22:11:12 +00:00
Arthur Lu bc6012af76 fix perttier action naming 2022-11-29 13:49:57 -08:00
Arthur Lu 29fca61a85 add and update phase 2 docs 2022-11-29 13:18:30 -08:00
Arthur Lu 5c4e4c38f4 add prettier lint action 2022-11-29 08:32:45 -08:00
Arthur Lu b7d79b6b50 remove .vscode folder, 
add .vscode to .gitignore
 2022-11-29 08:20:53 -08:00
Arthur Lu 0ca848e26b add prettier to devDependencies, 
add lint-prettier and fix-prettier commands
 2022-11-29 08:15:59 -08:00
Arthur Lu f99cfd0eff fix tag vertical fitting issue 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-26 18:39:33 -08:00
Arthur Lu a63552f32b fix ReviewCard css, 
fixes article tag overflow issue,
should resolve #85

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-26 18:00:09 -08:00
Arthur Lu ae2e14172d change #d-mealImg to #d-meal-img and #d-mealName to #d-meal-name 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-26 17:38:19 -08:00
Arthur Lu af4378ee40 fix some linting issues, 
fix bug in localStroage unit tests

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-26 16:06:24 -08:00
Arthur Lu 39aa535864 cleanup e2e test code 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-26 16:03:47 -08:00
Arthur Lu 9ff58a1c2c add sorting and filtering localStorage helper functions, 
add new unit tests for new helper functions

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-26 15:37:48 -08:00
Arthur LuandGitHub 33e619c2d5 Merge pull request #79 from cse110-fa22-group29/sprint-2 
Sprint 2
 2022-11-22 16:40:27 -08:00
Arthur Lu 83a0358869 fix form tag wrap issue 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-22 14:46:01 -08:00
Arthur Lu 5ba0dab1a1 fix flex-flow css linting issue 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 18:00:58 -08:00
Arthur Lu 1dfd8c91a2 fix css linting issues 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:55:44 -08:00
Arthur Lu ecff5313a1 increase timeout for e2e tests 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:38:34 -08:00
Arthur Lu a12de4e058 fix some more css issues 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:31:12 -08:00
Arthur Lu 9194dd5166 fix html linting and some css linting issues 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:27:18 -08:00
Arthur LuandGitHub 63a7d5ce1f Merge pull request #84 from cse110-fa22-group29/sprint-2-css-review-details 
Sprint 2 css review details
 2022-11-21 17:20:36 -08:00
Arthur Lu 9f9ac19b71 fix ReviewDetails CreatePage large tag display issue 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:20:12 -08:00
Arthur Lu 1cbefee26f fix favicon linking 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 14:37:37 -08:00
Arthur Lu dd56207892 fix update form listener 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 14:26:54 -08:00
Arthur Lu b24b1110f6 configure htmlHint and stylelint to use tab indentation, 
fix html and css linting issues
 2022-11-21 03:50:54 +00:00
Arthur Lu eed39f580f cleanup css in homepage.css and index.html 2022-11-21 03:17:32 +00:00
Arthur Lu 259018ca97 fix linting issue 2022-11-21 03:06:47 +00:00
Arthur Lu 142e6d93b6 set e2e test connection to 2 seconds 2022-11-21 02:53:50 +00:00
Arthur Lu a5ac2dc940 fix review card spacing and centering in homepage 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 17:03:55 -08:00
Arthur Lu 331f8e731c add some padding to icons 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 16:54:15 -08:00
Arthur LuandGitHub 19bbabe9b4 Merge pull request #82 from cse110-fa22-group29/sprint-2-css-review-details 
Implement css and js for ReviewDetails
 2022-11-20 16:41:41 -08:00
Arthur LuandGitHub 4336157371 Merge branch 'sprint-2' into sprint-2-css-review-details 2022-11-20 16:41:35 -08:00
Arthur Lu 9e82dae202 add comment for homepage mobile logic 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 16:39:51 -08:00
Arthur Lu ccbf060c8c Merge branch 'sprint-2' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into sprint-2 2022-11-20 16:31:34 -08:00
Arthur Lu 1f832aadd2 fix homepage structal issues, 
TODO: clean css

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 16:31:32 -08:00
Arthur Lu 7b7abad2e6 fix error in test syntax 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 15:33:31 -08:00
Arthur LuandGitHub 70c863c378 Merge branch 'add-multiple-testing' into sprint-2 2022-11-20 15:29:16 -08:00
Arthur Lu 12e818e079 fix js linting 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 15:23:22 -08:00
Arthur LuandGitHub 9c531771f2 Merge pull request #75 from cse110-fa22-group29/allow-for-user-uploaded-images 
implementation of basic image local storage
 2022-11-20 14:43:50 -08:00
Arthur Lu c5cc7bf309 update github actions with new npm script naming 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 14:36:13 -08:00
Arthur Lu dd3e0cfefb Merge branch 'sprint-2' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into sprint-2 2022-11-20 14:17:12 -08:00
Arthur Lu d284f0ddf2 change some npm scripts 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 14:17:10 -08:00
Arthur Lu c3944d476b fix lintHTML and lintCSS commands 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 14:12:26 -08:00
Arthur Lu 8a9a32414e Merge branch 'sprint-2' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into sprint-2 2022-11-20 14:07:02 -08:00
Arthur Lu e73a544ab2 fix js linting 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 14:07:01 -08:00
Arthur Lu 72e2f0fa03 comment appTestHelpers.js 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 13:43:42 -08:00
Arthur Lu 3b1b0cfd57 quick async fix 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 13:39:52 -08:00
Arthur Lu e7d8eaea59 fix issue with tag checking, 
modularize frequent app opperations in appTestHelpers.js,
fix isue with tage count checking

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 13:39:21 -08:00
Arthur Lu 1c1ac64c58 change e2e tests to use default images 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 12:34:29 -08:00
Arthur Lu 8338156cb8 fix delete test issue with alert handling 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 12:16:03 -08:00
Arthur Lu 20e9842aea fix expected values for ratings and src tests 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 12:00:59 -08:00
Arthur Lu 7035fa46ee fixes to tag-add-btn, 
fixes to tests with rating selection

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 11:42:30 -08:00
Arthur Lu 20afab9b1f remove create test review card reference 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 10:21:43 -08:00
Arthur Lu 2e95147336 Merge branch 'add-crud-e2e-testing' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into add-crud-e2e-testing 2022-11-18 23:26:54 -08:00
Arthur Lu ef5dccfd1a temp fix issue with root user 2022-11-18 23:26:51 -08:00
Arthur Lu 274a05fdc2 convert page.click() to button.click() 2022-11-18 20:43:55 -08:00
Arthur Lu 65815998e9 fix create new review star selection 2022-11-18 20:37:33 -08:00
Arthur Lu cac2b0bf07 populate part of add review, 
various bug fixes,
TODO: resolve issue with star selectors
 2022-11-18 20:36:10 -08:00
Arthur Lu 82be561bfe add wait for page navigation to applicable tests 2022-11-18 19:21:53 -08:00
Arthur LuandGitHub b75e4172b4 Merge pull request #72 from cse110-fa22-group29/storage-revamp 
Pull CRUD implementation changes from revamp-storage to add-crud-e2e-testing
 2022-11-18 19:12:22 -08:00
Arthur LuandGitHub 32323eaf83 Merge pull request #71 from cse110-fa22-group29/sprint-2 
Reflect changes to sprint-2 to storage-revamp
 2022-11-18 15:28:38 -08:00
Arthur LuandGitHub f332b27168 Merge pull request #70 from cse110-fa22-group29/remove-unused-files 
Reflect main changes to sprint-2
 2022-11-18 15:17:43 -08:00
Arthur LuandGitHub 0a39039e9c Merge pull request #69 from cse110-fa22-group29/remove-unused-files 
Remove unused files
 2022-11-18 15:16:40 -08:00
Arthur Lu baa722b55e remove unused files 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-18 15:15:20 -08:00
Arthur Lu 9cf7baf3e5 remove commented form from index 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-18 14:43:59 -08:00
Arthur Lu f6a9fb7fc5 remove implied init from localStorage unit tests 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-18 14:08:19 -08:00
Arthur LuandGitHub a91c9bc7ef Merge pull request #68 from cse110-fa22-group29/add-app-to-readme 
Add link to app in README.md
 2022-11-18 13:51:28 -08:00
Arthur Lu 5f84e700d1 update e2e test layout 2022-11-18 12:34:59 -08:00
Arthur LuandGitHub 46cee253f3 Merge branch 'main' into add-app-to-readme 2022-11-18 01:33:51 -08:00
Arthur Lu ca89953d41 add link to app in README.md 2022-11-18 09:31:53 +00:00