Arthur Lu
dd3e0cfefb
Merge branch 'sprint-2' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into sprint-2
2022-11-20 14:17:12 -08:00
Arthur Lu
d284f0ddf2
change some npm scripts
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-20 14:17:10 -08:00
Arthur Lu
c3944d476b
fix lintHTML and lintCSS commands
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-20 14:12:26 -08:00
Arthur Lu
8a9a32414e
Merge branch 'sprint-2' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into sprint-2
2022-11-20 14:07:02 -08:00
Arthur Lu
e73a544ab2
fix js linting
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-20 14:07:01 -08:00
Arthur Lu
72e2f0fa03
comment appTestHelpers.js
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-20 13:43:42 -08:00
Arthur Lu
3b1b0cfd57
quick async fix
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-20 13:39:52 -08:00
Arthur Lu
e7d8eaea59
fix issue with tag checking,
...
modularize frequent app opperations in appTestHelpers.js,
fix isue with tage count checking
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-20 13:39:21 -08:00
Arthur Lu
1c1ac64c58
change e2e tests to use default images
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-19 12:34:29 -08:00
Arthur Lu
8338156cb8
fix delete test issue with alert handling
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-19 12:16:03 -08:00
Arthur Lu
20e9842aea
fix expected values for ratings and src tests
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-19 12:00:59 -08:00
Arthur Lu
7035fa46ee
fixes to tag-add-btn,
...
fixes to tests with rating selection
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-19 11:42:30 -08:00
Arthur Lu
20afab9b1f
remove create test review card reference
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-19 10:21:43 -08:00
Arthur Lu
2e95147336
Merge branch 'add-crud-e2e-testing' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into add-crud-e2e-testing
2022-11-18 23:26:54 -08:00
Arthur Lu
ef5dccfd1a
temp fix issue with root user
2022-11-18 23:26:51 -08:00
Arthur Lu
274a05fdc2
convert page.click() to button.click()
2022-11-18 20:43:55 -08:00
Arthur Lu
65815998e9
fix create new review star selection
2022-11-18 20:37:33 -08:00
Arthur Lu
cac2b0bf07
populate part of add review,
...
various bug fixes,
TODO: resolve issue with star selectors
2022-11-18 20:36:10 -08:00
Arthur Lu
82be561bfe
add wait for page navigation to applicable tests
2022-11-18 19:21:53 -08:00
Arthur Lu and GitHub
b75e4172b4
Merge pull request #72 from cse110-fa22-group29/storage-revamp
...
Pull CRUD implementation changes from revamp-storage to add-crud-e2e-testing
2022-11-18 19:12:22 -08:00
Arthur Lu and GitHub
32323eaf83
Merge pull request #71 from cse110-fa22-group29/sprint-2
...
Reflect changes to sprint-2 to storage-revamp
2022-11-18 15:28:38 -08:00
Arthur Lu and GitHub
f332b27168
Merge pull request #70 from cse110-fa22-group29/remove-unused-files
...
Reflect main changes to sprint-2
2022-11-18 15:17:43 -08:00
Arthur Lu and GitHub
0a39039e9c
Merge pull request #69 from cse110-fa22-group29/remove-unused-files
...
Remove unused files
2022-11-18 15:16:40 -08:00
Arthur Lu
baa722b55e
remove unused files
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-18 15:15:20 -08:00
Arthur Lu
9cf7baf3e5
remove commented form from index
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-18 14:43:59 -08:00
Arthur Lu
f6a9fb7fc5
remove implied init from localStorage unit tests
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-18 14:08:19 -08:00
Arthur Lu and GitHub
a91c9bc7ef
Merge pull request #68 from cse110-fa22-group29/add-app-to-readme
...
Add link to app in README.md
2022-11-18 13:51:28 -08:00
Arthur Lu
5f84e700d1
update e2e test layout
2022-11-18 12:34:59 -08:00
Arthur Lu and GitHub
46cee253f3
Merge branch 'main' into add-app-to-readme
2022-11-18 01:33:51 -08:00
Arthur Lu
ca89953d41
add link to app in README.md
2022-11-18 09:31:53 +00:00
Arthur Lu
425bc45453
fix unit test action stall issue
2022-11-18 09:23:54 +00:00
Arthur Lu
3422f584f9
fix linting in js
2022-11-18 07:56:07 +00:00
Arthur Lu
89b7319dd8
cleanup unused html and js code
2022-11-18 07:52:43 +00:00
Arthur Lu
5e83338668
update unit tests to match new localStorage implementations
2022-11-18 07:51:08 +00:00
Arthur Lu
6493fbd171
modularize localStorage calls into localStorage.js in preparation for unit testing
2022-11-18 07:13:53 +00:00
Arthur Lu
6c00246e2d
fix linting issues
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-17 15:33:12 -08:00
Arthur Lu
c45aec116b
fix e2e test for create,
...
split create test into two parts,
split other test templates into two parts
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-17 15:32:37 -08:00
Arthur Lu
1518fda766
add e2e tests for update and delete,
...
fix package.json commadns for lint and fix-style
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-17 13:54:58 -08:00
Arthur Lu
c66f43f6e9
add empty crud e2e tests
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-17 12:32:38 -08:00
Arthur Lu
0ebf9f8a20
fix typo in package.json
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-17 11:38:05 -08:00
Arthur Lu
d9c28096fd
add e2e framework ADR
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-16 17:41:45 -08:00
Arthur Lu
7abc995ffe
fix linting errors
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-16 16:46:02 -08:00
Arthur Lu
cbe8da609c
fix js-unittest.yml to start local server
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-16 16:18:35 -08:00
Arthur Lu
dd7d876f29
add dependencies to package.json,
...
add http-server script to package.json,
add simple e2e test in main.e2e.test.js
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-16 16:10:31 -08:00
Arthur Lu and GitHub
540d6563d8
Merge pull request #43 from cse110-fa22-group29/sprint-1
...
Sprint 1
2022-11-14 18:16:23 -08:00
Arthur Lu
b6f3a57231
adjust JS Unit tests to be more permissive
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-15 01:11:48 +00:00
Arthur Lu
837ba92d7d
fix css style issues,
...
removed css for rating stars
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-15 01:08:32 +00:00
Arthur Lu
66dd92f0dc
fix js linting
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-15 00:53:07 +00:00
Arthur Lu
09dd837081
add phase1.mp4
2022-11-14 03:53:55 +00:00
Arthur Lu
8354e561e5
Merge branch 'main' into sprint-1
2022-11-14 03:36:01 +00:00
Arthur Lu
39cb507bc5
move html and css to source folder
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-13 22:33:00 +00:00
Arthur Lu and GitHub
7f892d2491
Merge pull request #56 from cse110-fa22-group29/sprint-1
...
Merge with HTMLhint branch
2022-11-13 13:49:26 -08:00
Arthur Lu and GitHub
e068e51575
Merge branch '45-adding-htmlhint-to-repo' into sprint-1
2022-11-13 13:49:04 -08:00
Arthur Lu
37ea4d7e6d
fix merge conflicts
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-13 21:47:27 +00:00
Arthur Lu
1819f5042c
remove npx call in package.json scripts
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-13 21:40:42 +00:00
Arthur Lu
28e8415589
change css linting file naming
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-13 21:31:15 +00:00
Arthur Lu
34225f651f
fix package.json
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-13 21:30:31 +00:00
Arthur Lu
0896d4ff39
fix sprint1 meeting notes naming
2022-11-13 05:42:13 +00:00
Arthur Lu
64a0aef48b
update pipeline arch linting and unit testing ADRs
2022-11-13 05:25:56 +00:00
Arthur Lu and GitHub
0c0b49264e
Merge pull request #47 from cse110-fa22-group29/fix-es6-compatibility
...
Fix JS unit test ES6 compatibility
2022-11-11 08:58:39 -08:00
Arthur Lu
8450227035
update pahse1.md
2022-11-11 08:18:53 +00:00
Arthur Lu
1a8d494fe2
fix typo in js-unittest.yml action
2022-11-11 02:55:25 +00:00
Arthur Lu
d274a8a442
update js-unittest action to use nodejs v 18
2022-11-11 02:41:23 +00:00
Arthur Lu
8b2ae89bd2
switch localStorage mock to mock-local-storage,
...
fix unit tests to work with ES6 import syntax,
remove testenv module
2022-11-11 02:39:40 +00:00
Arthur Lu
b85a73400d
add another unit test to localStorage.test.js,
...
reflect fixes to packages.json from main
2022-11-10 22:33:47 +00:00
Arthur Lu
338eeac38f
fix scripts in package.json for correct recursive calling
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-10 01:41:27 +00:00
Arthur Lu
1718c7cedb
move localStorage util to localStorage.js,
...
update main,js to rquire localStroage,
add simple unit tests to localStroage.test.js,
create symlink of testenv.js to source/assets/scripts,
update package.json with proper recursive call
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-10 01:35:41 +00:00
Arthur Lu
aa69ef1ab7
fix devDependencies list in package.json
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-08 17:53:55 +00:00
Arthur Lu
7392d25c42
implement linting action,
...
fix action naming issue
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-08 04:09:15 +00:00
Arthur Lu
a6015aff3b
implement basic linting with eslint,
...
fix linting errors in testenv module
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-08 03:09:10 +00:00
Arthur Lu
22a3e9f4f4
remove git from js unit test ci action
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-08 02:03:50 +00:00
Arthur Lu
3043c6e157
fix locality issue in mocha unit tests,
...
move sample helper functions for localStorage unit testing
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-08 01:33:35 +00:00
Arthur Lu
d0be8336be
update phase1 diagram with updated mocha framework
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-08 00:05:57 +00:00
Arthur Lu
0f622d16de
switch to mocha for test latency improvements
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-08 00:00:15 +00:00
Arthur Lu
c7c395c832
make workflow naming shorter
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-07 23:43:40 +00:00
Arthur Lu
6f915678b5
sudo all run commands
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-07 23:38:53 +00:00
Arthur Lu
1798ad1140
implement js unittest action
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-07 23:31:13 +00:00
Arthur Lu and GitHub
1c7b1de7d3
Merge pull request #37 from cse110-fa22-group29/js-unit-test
...
Pull new JS unit tests from js-unit-test to js-unit-test-ci
2022-11-07 15:27:51 -08:00
Arthur Lu
b680b83dcc
switch toBe to toStrictEqual in testenv.test.js
2022-11-07 21:17:05 +00:00
Arthur Lu
c95834ca31
add .gitignore
2022-11-06 22:57:42 +00:00
Arthur Lu
f5b2953c33
fix testenv unit test naming
2022-11-06 22:53:14 +00:00
Arthur Lu
7d5ec8a704
add .gitignore from js-unit-test
2022-11-06 22:49:36 +00:00
Arthur Lu
2d4f8e48c2
move package.json to root dir
2022-11-06 22:39:30 +00:00
Arthur Lu
cf11ab22b4
fix drawio diagram
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-06 14:31:31 -08:00
Arthur Lu
ec305e667d
switch unit test framework to jest,
...
remove framework unittest,
add helper module to create unit testing environment
2022-11-06 05:46:23 +00:00
Arthur Lu
d5a36a913e
implement unittest.js, implement unittest.test.js
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-05 20:19:14 -07:00
Arthur Lu and Graydogminer
f80bf799a2
update overall pipeline plan for phase 1
...
Co-authored-by: Graydogminer <Graydogminer@users.noreply.github.com >
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-05 18:36:22 -07:00
Arthur Lu
9e1bd31c36
add module exports to unittest.js
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-05 17:49:41 -07:00
Arthur Lu
9a9fe0c5d7
add template for unittest abstraction layer
2022-11-05 00:36:55 -07:00
Arthur Lu
874ca152c9
create folder /admin/cipipeline,
...
create file phase1.drawio.png,
create file phase1.md,
create file phase1.mp4
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-11-04 16:05:41 -07:00
Arthur Lu and GitHub
c1f82fe650
Create deploy-githubpages.yml
...
- derive from Static HTML workflow
- change to deploy only form source folder
2022-11-02 17:04:05 -07:00
Arthur Lu
cb2b947bba
upload diagram for resume-builder idea
2022-10-23 22:18:03 -07:00
Arthur Lu and GitHub
d93598de3d
Update team.md with Arthur Lu's bio
2022-10-15 14:50:57 -07:00
Arthur Lu
2e9a7b559e
add signed rules for Arthur Lu
...
Signed-off-by: Arthur Lu <learthurgo@gmail.com >
2022-10-14 16:16:11 -07:00