alu/cse110-fa22-group29
1
0
Fork 0
mirror of https://github.com/cse110-fa22-group29/cse110-fa22-group29.git synced 2026-08-28 13:18:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
415 Commits 4 Branches 1 Tag
29fca61a85b98d4a1f6251c7f55132f670ed4719
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Arthur Lu 29fca61a85 add and update phase 2 docs 2022-11-29 13:18:30 -08:00
Arthur LuandGitHub 33e619c2d5 Merge pull request #79 from cse110-fa22-group29/sprint-2 
Sprint 2
 2022-11-22 16:40:27 -08:00
Arthur Lu 83a0358869 fix form tag wrap issue 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-22 14:46:01 -08:00
Arthur Lu 5ba0dab1a1 fix flex-flow css linting issue 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 18:00:58 -08:00
Arthur Lu 1dfd8c91a2 fix css linting issues 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:55:44 -08:00
Arthur Lu ecff5313a1 increase timeout for e2e tests 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:38:34 -08:00
Arthur Lu a12de4e058 fix some more css issues 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:31:12 -08:00
Arthur Lu 9194dd5166 fix html linting and some css linting issues 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:27:18 -08:00
Arthur LuandGitHub 63a7d5ce1f Merge pull request #84 from cse110-fa22-group29/sprint-2-css-review-details 
Sprint 2 css review details
 2022-11-21 17:20:36 -08:00
Arthur Lu 9f9ac19b71 fix ReviewDetails CreatePage large tag display issue 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 17:20:12 -08:00
Arthur Lu 1cbefee26f fix favicon linking 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 14:37:37 -08:00
Arthur Lu dd56207892 fix update form listener 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-21 14:26:54 -08:00
Arthur Lu b24b1110f6 configure htmlHint and stylelint to use tab indentation, 
fix html and css linting issues
 2022-11-21 03:50:54 +00:00
Arthur Lu eed39f580f cleanup css in homepage.css and index.html 2022-11-21 03:17:32 +00:00
Arthur Lu 259018ca97 fix linting issue 2022-11-21 03:06:47 +00:00
Arthur Lu 142e6d93b6 set e2e test connection to 2 seconds 2022-11-21 02:53:50 +00:00
Arthur Lu a5ac2dc940 fix review card spacing and centering in homepage 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 17:03:55 -08:00
Arthur Lu 331f8e731c add some padding to icons 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 16:54:15 -08:00
Arthur LuandGitHub 19bbabe9b4 Merge pull request #82 from cse110-fa22-group29/sprint-2-css-review-details 
Implement css and js for ReviewDetails
 2022-11-20 16:41:41 -08:00
Arthur LuandGitHub 4336157371 Merge branch 'sprint-2' into sprint-2-css-review-details 2022-11-20 16:41:35 -08:00
Arthur Lu 9e82dae202 add comment for homepage mobile logic 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 16:39:51 -08:00
Arthur Lu ccbf060c8c Merge branch 'sprint-2' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into sprint-2 2022-11-20 16:31:34 -08:00
Arthur Lu 1f832aadd2 fix homepage structal issues, 
TODO: clean css

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 16:31:32 -08:00
Arthur Lu 7b7abad2e6 fix error in test syntax 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 15:33:31 -08:00
Arthur LuandGitHub 70c863c378 Merge branch 'add-multiple-testing' into sprint-2 2022-11-20 15:29:16 -08:00
Arthur Lu 12e818e079 fix js linting 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 15:23:22 -08:00
Arthur LuandGitHub 9c531771f2 Merge pull request #75 from cse110-fa22-group29/allow-for-user-uploaded-images 
implementation of basic image local storage
 2022-11-20 14:43:50 -08:00
Arthur Lu c5cc7bf309 update github actions with new npm script naming 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 14:36:13 -08:00
Arthur Lu dd3e0cfefb Merge branch 'sprint-2' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into sprint-2 2022-11-20 14:17:12 -08:00
Arthur Lu d284f0ddf2 change some npm scripts 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 14:17:10 -08:00
Arthur Lu c3944d476b fix lintHTML and lintCSS commands 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 14:12:26 -08:00
Arthur Lu 8a9a32414e Merge branch 'sprint-2' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into sprint-2 2022-11-20 14:07:02 -08:00
Arthur Lu e73a544ab2 fix js linting 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 14:07:01 -08:00
Arthur Lu 72e2f0fa03 comment appTestHelpers.js 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 13:43:42 -08:00
Arthur Lu 3b1b0cfd57 quick async fix 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 13:39:52 -08:00
Arthur Lu e7d8eaea59 fix issue with tag checking, 
modularize frequent app opperations in appTestHelpers.js,
fix isue with tage count checking

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-20 13:39:21 -08:00
Arthur Lu 1c1ac64c58 change e2e tests to use default images 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 12:34:29 -08:00
Arthur Lu 8338156cb8 fix delete test issue with alert handling 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 12:16:03 -08:00
Arthur Lu 20e9842aea fix expected values for ratings and src tests 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 12:00:59 -08:00
Arthur Lu 7035fa46ee fixes to tag-add-btn, 
fixes to tests with rating selection

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 11:42:30 -08:00
Arthur Lu 20afab9b1f remove create test review card reference 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-19 10:21:43 -08:00
Arthur Lu 2e95147336 Merge branch 'add-crud-e2e-testing' of https://github.com/cse110-fa22-group29/cse110-fa22-group29 into add-crud-e2e-testing 2022-11-18 23:26:54 -08:00
Arthur Lu ef5dccfd1a temp fix issue with root user 2022-11-18 23:26:51 -08:00
Arthur Lu 274a05fdc2 convert page.click() to button.click() 2022-11-18 20:43:55 -08:00
Arthur Lu 65815998e9 fix create new review star selection 2022-11-18 20:37:33 -08:00
Arthur Lu cac2b0bf07 populate part of add review, 
various bug fixes,
TODO: resolve issue with star selectors
 2022-11-18 20:36:10 -08:00
Arthur Lu 82be561bfe add wait for page navigation to applicable tests 2022-11-18 19:21:53 -08:00
Arthur LuandGitHub b75e4172b4 Merge pull request #72 from cse110-fa22-group29/storage-revamp 
Pull CRUD implementation changes from revamp-storage to add-crud-e2e-testing
 2022-11-18 19:12:22 -08:00
Arthur LuandGitHub 32323eaf83 Merge pull request #71 from cse110-fa22-group29/sprint-2 
Reflect changes to sprint-2 to storage-revamp
 2022-11-18 15:28:38 -08:00
Arthur LuandGitHub f332b27168 Merge pull request #70 from cse110-fa22-group29/remove-unused-files 
Reflect main changes to sprint-2
 2022-11-18 15:17:43 -08:00
Arthur LuandGitHub 0a39039e9c Merge pull request #69 from cse110-fa22-group29/remove-unused-files 
Remove unused files
 2022-11-18 15:16:40 -08:00
Arthur Lu baa722b55e remove unused files 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-18 15:15:20 -08:00
Arthur Lu 9cf7baf3e5 remove commented form from index 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-18 14:43:59 -08:00
Arthur Lu f6a9fb7fc5 remove implied init from localStorage unit tests 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-18 14:08:19 -08:00
Arthur LuandGitHub a91c9bc7ef Merge pull request #68 from cse110-fa22-group29/add-app-to-readme 
Add link to app in README.md
 2022-11-18 13:51:28 -08:00
Arthur Lu 5f84e700d1 update e2e test layout 2022-11-18 12:34:59 -08:00
Arthur LuandGitHub 46cee253f3 Merge branch 'main' into add-app-to-readme 2022-11-18 01:33:51 -08:00
Arthur Lu ca89953d41 add link to app in README.md 2022-11-18 09:31:53 +00:00
Arthur Lu 425bc45453 fix unit test action stall issue 2022-11-18 09:23:54 +00:00
Arthur Lu 3422f584f9 fix linting in js 2022-11-18 07:56:07 +00:00
Arthur Lu 89b7319dd8 cleanup unused html and js code 2022-11-18 07:52:43 +00:00
Arthur Lu 5e83338668 update unit tests to match new localStorage implementations 2022-11-18 07:51:08 +00:00
Arthur Lu 6493fbd171 modularize localStorage calls into localStorage.js in preparation for unit testing 2022-11-18 07:13:53 +00:00
Arthur Lu 6c00246e2d fix linting issues 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-17 15:33:12 -08:00
Arthur Lu c45aec116b fix e2e test for create, 
split create test into two parts,
split other test templates into two parts

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-17 15:32:37 -08:00
Arthur Lu 1518fda766 add e2e tests for update and delete, 
fix package.json commadns for lint and fix-style

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-17 13:54:58 -08:00
Arthur Lu c66f43f6e9 add empty crud e2e tests 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-17 12:32:38 -08:00
Arthur Lu 0ebf9f8a20 fix typo in package.json 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-17 11:38:05 -08:00
Arthur Lu d9c28096fd add e2e framework ADR 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-16 17:41:45 -08:00
Arthur Lu 7abc995ffe fix linting errors 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-16 16:46:02 -08:00
Arthur Lu cbe8da609c fix js-unittest.yml to start local server 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-16 16:18:35 -08:00
Arthur Lu dd7d876f29 add dependencies to package.json, 
add http-server script to package.json,
add simple e2e test in main.e2e.test.js

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-16 16:10:31 -08:00
Arthur LuandGitHub 540d6563d8 Merge pull request #43 from cse110-fa22-group29/sprint-1 
Sprint 1
 2022-11-14 18:16:23 -08:00
Arthur Lu b6f3a57231 adjust JS Unit tests to be more permissive 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-15 01:11:48 +00:00
Arthur Lu 837ba92d7d fix css style issues, 
removed css for rating stars

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-15 01:08:32 +00:00
Arthur Lu 66dd92f0dc fix js linting 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-15 00:53:07 +00:00
Arthur Lu 09dd837081 add phase1.mp4 2022-11-14 03:53:55 +00:00
Arthur Lu 8354e561e5 Merge branch 'main' into sprint-1 2022-11-14 03:36:01 +00:00
Arthur Lu 39cb507bc5 move html and css to source folder 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-13 22:33:00 +00:00
Arthur LuandGitHub 7f892d2491 Merge pull request #56 from cse110-fa22-group29/sprint-1 
Merge with HTMLhint branch
 2022-11-13 13:49:26 -08:00
Arthur LuandGitHub e068e51575 Merge branch '45-adding-htmlhint-to-repo' into sprint-1 2022-11-13 13:49:04 -08:00
Arthur Lu 37ea4d7e6d fix merge conflicts 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-13 21:47:27 +00:00
Arthur Lu 1819f5042c remove npx call in package.json scripts 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-13 21:40:42 +00:00
Arthur Lu 28e8415589 change css linting file naming 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-13 21:31:15 +00:00
Arthur Lu 34225f651f fix package.json 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-13 21:30:31 +00:00
Arthur Lu 0896d4ff39 fix sprint1 meeting notes naming 2022-11-13 05:42:13 +00:00
Arthur Lu 64a0aef48b update pipeline arch linting and unit testing ADRs 2022-11-13 05:25:56 +00:00
Arthur LuandGitHub 0c0b49264e Merge pull request #47 from cse110-fa22-group29/fix-es6-compatibility 
Fix JS unit test ES6 compatibility
 2022-11-11 08:58:39 -08:00
Arthur Lu 8450227035 update pahse1.md 2022-11-11 08:18:53 +00:00
Arthur Lu 1a8d494fe2 fix typo in js-unittest.yml action 2022-11-11 02:55:25 +00:00
Arthur Lu d274a8a442 update js-unittest action to use nodejs v 18 2022-11-11 02:41:23 +00:00
Arthur Lu 8b2ae89bd2 switch localStorage mock to mock-local-storage, 
fix unit tests to work with ES6 import syntax,
remove testenv module
 2022-11-11 02:39:40 +00:00
Arthur Lu b85a73400d add another unit test to localStorage.test.js, 
reflect fixes to packages.json from main
 2022-11-10 22:33:47 +00:00
Arthur Lu 338eeac38f fix scripts in package.json for correct recursive calling 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-10 01:41:27 +00:00
Arthur Lu 1718c7cedb move localStorage util to localStorage.js, 
update main,js to rquire localStroage,
add simple unit tests to localStroage.test.js,
create symlink of testenv.js to source/assets/scripts,
update package.json with proper recursive call

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-10 01:35:41 +00:00
Arthur Lu aa69ef1ab7 fix devDependencies list in package.json 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-08 17:53:55 +00:00
Arthur Lu 7392d25c42 implement linting action, 
fix action naming issue

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-08 04:09:15 +00:00
Arthur Lu a6015aff3b implement basic linting with eslint, 
fix linting errors in testenv module

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-08 03:09:10 +00:00
Arthur Lu 22a3e9f4f4 remove git from js unit test ci action 
Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-08 02:03:50 +00:00
Arthur Lu 3043c6e157 fix locality issue in mocha unit tests, 
move sample helper functions for localStorage unit testing

Signed-off-by: Arthur Lu <learthurgo@gmail.com>
 2022-11-08 01:33:35 +00:00