fix makefile phony targets

.gitea/workflows/lint.yaml

@@ -1,59 +0,0 @@
-name: ProxmoxAAS-Dashboard Code Style Check
-run-name: Code style check on ${{ gitea.repository }} ${{ gitea.ref_name }} ${{ gitea.sha }}
-on: 
-  push:
-    branches:
-    - "*"
-
-jobs: 
-  lint-check:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check Out Repository
-        uses: actions/checkout@v4
-        
-      - name: Initialize Runner
-        uses: actions/setup-node@v4
-
-      - name: Install Linters
-        run: |
-          npm install --no-save \
-            @eslint/eslintrc \
-            @eslint/js \
-            eslint \
-            globals \
-            html-validate \
-            stylelint \
-            stylelint-config-standard
-
-      - name: Verify Linters
-        run: |
-          npx html-validate --version
-          npx stylelint --version
-          npx eslint --version
-
-      - name: Run HTMLValidate
-        id: html_lint
-        run: npx html-validate --config dev_config/.htmlvalidate.json "web/html/**/*"
-
-      - name: Run Stylelint
-        id: style_lint
-        if: always()
-        run: npx stylelint --config dev_config/.stylelintrc.json --formatter verbose --fix "web/css/**/*.css"
-
-      - name: Run ESLint
-        id: js_lint
-        if: always()
-        env:
-          DEBUG: eslint:cli-engine
-        run: npx eslint --config dev_config/eslint.config.mjs --fix web/scripts/
-
-      - name: Verify Linters
-        if: always()
-        run: |
-          if [ "${{ steps.html_lint.outcome }}" != "success" ] || \
-             [ "${{ steps.style_lint.outcome }}" != "success" ] || \
-             [ "${{ steps.js_lint.outcome }}" != "success" ]; then
-            echo "At least one linter failed."
-            exit 1
-          fi

.gitignore

@@ -1,5 +1,3 @@
 **/config.json
-**/package-lock.json
-**/node_modules
 dist/*
 go.sum

Makefile

@@ -1,13 +1,14 @@
-.PHONY: build test clean wfa-js
+.PHONY: build build-web build-wfa-js clean clean-wfa-js ensure-dist workflow-init
 
-build: clean build-wfa-js
+build: clean ensure-dist build-web build-wfa-js
 	@echo "======================== Building Binary ======================="
-	mkdir -p dist
 # resolve symbolic links in web by copying it into dist/web/
-	cp -rL web/ dist/web/
 	CGO_ENABLED=0 go build -tags release -ldflags="-s -w" -v -o dist/ .
 
-build-wfa-js:
+build-web: ensure-dist
+	cp -rL web/ dist/web/
+
+build-wfa-js: ensure-dist
 	$(MAKE) -C WFA-JS
 	cp -f WFA-JS/dist/* web/modules
 
@@ -18,3 +19,9 @@ clean: clean-wfa-js
 
 clean-wfa-js:
 	$(MAKE) clean -C WFA-JS
+
+ensure-dist:
+	mkdir -p dist
+
+workflow-init: ensure-dist build-web
+	cp -r dev_config/. .

app/app.go

@@ -6,7 +6,7 @@ import (
 	"log"
 	"proxmoxaas-dashboard/app/common"
 	"proxmoxaas-dashboard/app/routes"
-	"proxmoxaas-dashboard/dist/web" // go will complain here until the first build
+	"web" // go will complain here until the first build
 
 	"github.com/gin-gonic/gin"
 	"github.com/tdewolff/minify/v2"

dev_config/.htmlvalidateignore

@@ -0,0 +1,3 @@
+web/modules/*
+WFA-JS/*
+dist/*

dev_config/.stylelintignore

@@ -0,0 +1,3 @@
+web/modules/*
+WFA-JS/*
+dist/*

dev_config/eslint.config.mjs

@@ -1,29 +1,33 @@
-import { defineConfig } from "eslint/config";
+import { defineConfig, globalIgnores } from "eslint/config";
 import globals from "globals";
 import js from "@eslint/js";
 
-export default defineConfig([js.configs.recommended,{
+export default defineConfig([
-    languageOptions: {
+    js.configs.recommended,
-        globals: {
+    globalIgnores(["dist/", "web/modules", "WFA-JS"]),
-            ...globals.browser,
+    {
+        languageOptions: {
+            globals: {
+                ...globals.browser,
+            },
+            ecmaVersion: "latest",
+            sourceType: "module",
         },
-        ecmaVersion: "latest",
+        rules: {
-        sourceType: "module",
+            "no-tabs": ["error", {
-    },
+                allowIndentationTabs: true,
-    rules: {
+            }],
-        "no-tabs": ["error", {
+            indent: ["error", "tab"],
-            allowIndentationTabs: true,
+            "linebreak-style": ["error", "unix"],
-        }],
+            quotes: ["error", "double"],
-        indent: ["error", "tab"],
+            semi: ["error", "always"],
-        "linebreak-style": ["error", "unix"],
+            "brace-style": ["error", "stroustrup", { allowSingleLine: false }],
-        quotes: ["error", "double"],
+            "no-unused-vars": ["warn", { 
-        semi: ["error", "always"],
+                "argsIgnorePattern": "^_",
-        "brace-style": ["error", "stroustrup", { allowSingleLine: false }],
+                "varsIgnorePattern": "^_",
-        "no-unused-vars": ["warn", { 
+                "caughtErrorsIgnorePattern": "^_"
-            "argsIgnorePattern": "^_",
+            }],
-            "varsIgnorePattern": "^_",
+            "prefer-const": ["error"]
-            "caughtErrorsIgnorePattern": "^_"
+        },
-        }],
+    }
-		"prefer-const": ["error"]
+]);
-    },
-}]);

go.mod

@@ -8,9 +8,11 @@ require (
 	github.com/go-viper/mapstructure/v2 v2.5.0
 	github.com/tdewolff/minify/v2 v2.24.13
 	proxmoxaas-common-lib v0.0.0
+	web v0.0.0
 )
 
 replace proxmoxaas-common-lib => ./proxmoxaas-common-lib
+replace web => ./dist/web
 
 require (
 	github.com/bytedance/gopkg v0.1.4 // indirect

web/go.mod

@@ -0,0 +1,3 @@
+module web
+
+go 1.26.0

web/html/account.html

@@ -58,9 +58,9 @@
 				<div id="body">
 					<form method="dialog" class="input-grid" style="grid-template-columns: auto 1fr;" id="form">
 						<label for="new-password">New Password</label>
-						<input class="w3-input w3-border" id="new-password" name="new-password" type="password" required>
+						<input class="w3-input w3-border" id="new-password" name="new-password" type="password" autocomplete="new-password" required>
 						<label for="confirm-password">Confirm Password</label>
-						<input class="w3-input w3-border" id="confirm-password" name="confirm-password" type="password" required>
+						<input class="w3-input w3-border" id="confirm-password" name="confirm-password" type="password" autocomplete="new-password" required>
 					</form>
 				</div>
 				<div id="controls" class="w3-center w3-container">

web/html/index.html

@@ -114,9 +114,9 @@
 										<label class="container-specific none" for="rootfs-size">ROOTFS Size (GiB)</label>
 										<input class="w3-input w3-border container-specific none" name="rootfs-size" id="rootfs-size" type="number" min="0" max="131072" required disabled>
 										<label class="container-specific none" for="password">Password</label>
-										<input class="w3-input w3-border container-specific none" name="password" id="password" type="password" required disabled>
+										<input class="w3-input w3-border container-specific none" name="password" id="password" type="password" autocomplete="new-password" required disabled>
 										<label class="container-specific none" for="confirm-password">Confirm Password</label>
-										<input class="w3-input w3-border container-specific none" name="confirm-password" id="confirm-password" type="password" required disabled>
+										<input class="w3-input w3-border container-specific none" name="confirm-password" id="confirm-password" type="password" autocomplete="new-password" required disabled>
 									</form>
 								</div>
 								<div id="controls" class="w3-center w3-container">

web/modules/wfa.js

@@ -560,7 +560,7 @@ export default function init (path) {
 			const wasm = obj.instance;
 			global.wfa = wasm
 			go.run(wasm);
-			res()
+			res(wasm)
 		}
 		if ('instantiateStreaming' in WebAssembly) {
 			WebAssembly.instantiateStreaming(fetch(path), go.importObject).then(function (obj) {

web/scripts/dialog.js

@@ -96,7 +96,7 @@ class ErrorDialog extends HTMLElement {
 				}
 				navigator.clipboard.writeText(errors);
 			}
-			this.parentElement.removeChild(this);
+			this.dialog.close();
 		});
 	}
 

web/scripts/index.js

@@ -5,10 +5,12 @@ import wfaInit from "../modules/wfa.js";
 
 window.addEventListener("DOMContentLoaded", init);
 
+var wfa;
+
 async function init () {
 	setAppearance();
 
-	wfaInit("modules/wfa.wasm");
+	wfa = await wfaInit("modules/wfa.wasm");
 	initInstances();
 
 	document.querySelector("#instance-add").addEventListener("click", handleInstanceAddButton);
@@ -272,8 +274,8 @@ function sortInstances () {
 		};
 		criteria = (item, query) => {
 			// lower is better
-			const { score, CIGAR } = global.wfa.wfAlign(query, item, penalties, true);
+			const { score, CIGAR } = wfa.wfAlign(query, item, penalties, true);
-			const alignment = global.wfa.DecodeCIGAR(CIGAR);
+			const alignment = wfa.DecodeCIGAR(CIGAR);
 			return { score: score / item.length, alignment };
 		};
 	}

web/scripts/login.js

@@ -6,6 +6,7 @@ window.addEventListener("DOMContentLoaded", init);
 async function init () {
 	await deleteAllCookies();
 	setAppearance();
+
 	const formSubmitButton = document.querySelector("#submit");
 	formSubmitButton.addEventListener("click", async (e) => {
 		e.preventDefault();