From 455ed353c6e8f2b5c6a65e22860bca2658ca7bb8 Mon Sep 17 00:00:00 2001
From: Arthur Lu <root@tronnet.net>
Date: Mon, 7 Apr 2025 23:17:23 +0000
Subject: [PATCH] remove commented code, remove Name field from select using ID
 instead

---
 app/common/types.go       | 1 -
 app/routes/login.go       | 7 ++-----
 web/templates/select.tmpl | 2 +-
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/app/common/types.go b/app/common/types.go
index 1a45fdc..1edf2fa 100644
--- a/app/common/types.go
+++ b/app/common/types.go
@@ -16,7 +16,6 @@ type StaticFile struct {
 // type used for templated <select>
 type Select struct {
 	ID      string
-	Name    string
 	Options []Option
 }
 
diff --git a/app/routes/login.go b/app/routes/login.go
index 9fae783..32a95bb 100644
--- a/app/routes/login.go
+++ b/app/routes/login.go
@@ -30,12 +30,10 @@ func GetLoginRealms() ([]Realm, error) {
 	}
 	res, code, err := common.RequestGetAPI("/proxmox/access/domains", ctx)
 	if err != nil {
-		//HandleNonFatalError(c, err)
 		return realms, err
 	}
 	if code != 200 { // we expect /access/domains to always be avaliable
-		//HandleNonFatalError(c, err)
-		return realms, fmt.Errorf("request to /proxmox/access/do9mains resulted in %+v", res)
+		return realms, fmt.Errorf("request to /proxmox/access/domains resulted in %+v", res)
 	}
 
 	for _, v := range ctx.Body["data"].([]any) {
@@ -58,8 +56,7 @@ func HandleGETLogin(c *gin.Context) {
 	}
 
 	sel := common.Select{
-		ID:   "realm",
-		Name: "realm",
+		ID: "realm",
 	}
 
 	for _, realm := range realms {
diff --git a/web/templates/select.tmpl b/web/templates/select.tmpl
index 106d8b4..45d0e07 100644
--- a/web/templates/select.tmpl
+++ b/web/templates/select.tmpl
@@ -1,5 +1,5 @@
 {{define "select"}}
-<select class="w3-select w3-border" id="{{.ID}}" name="{{.Name}}">
+<select class="w3-select w3-border" id="{{.ID}}" name="{{.ID}}">
 {{range .Options}}
 	{{if .Selected}}
 		<option value="{{.Value}}" selected>{{.Display}}</option>