Merge branch '45-adding-htmlhint-to-repo' into sprint-1

This commit is contained in:
Arthur Lu 2022-11-13 13:49:04 -08:00 committed by GitHub
commit e068e51575
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
25 changed files with 709 additions and 616 deletions

23
.github/workflows/css-linting.yml vendored Normal file
View File

@ -0,0 +1,23 @@
name: CSS Linting
on:
pull_request:
branches:
- main
# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:
jobs:
# Single deploy job since we're just deploying
test:
runs-on: ubuntu-latest
steps:
- name: Install apt updates
run: sudo apt -y update; sudo apt -y upgrade;
- name: Checkout
uses: actions/checkout@v3
- name: Install dependencies
run: sudo npm install
- name: Run tests
run: sudo npm run lintCSS

23
.github/workflows/html-linting.yml vendored Normal file
View File

@ -0,0 +1,23 @@
name: HTML Linting
on:
pull_request:
branches:
- main
# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:
jobs:
# Single deploy job since we're just deploying
test:
runs-on: ubuntu-latest
steps:
- name: Install apt updates
run: sudo apt -y update; sudo apt -y upgrade;
- name: Checkout
uses: actions/checkout@v3
- name: Install dependencies
run: sudo npm install
- name: Run tests
run: sudo npm run lintHTML

3
.htmlhintrc Normal file
View File

@ -0,0 +1,3 @@
{
"attr-value-not-empty": false
}

3
.stylelintrc.json Normal file
View File

@ -0,0 +1,3 @@
{
"extends": "stylelint-config-standard"
}

View File

@ -0,0 +1,36 @@
# Meeting Minutes (11/09/2022)
## Team 29: Hackers1995
## Meeting Topic: Weekly TA Catchup with Gagan
We are meeting with Gagan to discuss progress made on Sprint 1 and testing strategies that we need to keep in mind as we continue developing.
## Attendance
1. Rhea Bhutada
2. George Dubinin
3. Gagan Gopalaiah
4. Sanjit Joseph
## Meeting Details
- When: 11/09/2022 at 3:30PM
- Where: Zoom
## Agenda:
## Discussion Points by Gagan
- Provided updates on first sprint
- Testing Tips
- functionality testing
- test one feature
- test individual functions
- static testing
- checking if its meeting the conventions and standards for specific programming language
- linting
- specific to programming language
- overall
- if tested properly, we reduce problems end-to-end testing
- Documentation
- What the code does?
- What the file is for?
- JS Docs
## End Time
- 11/09/2022 at 4:00PM

View File

@ -4,12 +4,17 @@
"type": "module", "type": "module",
"scripts": { "scripts": {
"test": "mocha --recursive --require mock-local-storage './{,!(node_modules)/**}/*.test.js'", "test": "mocha --recursive --require mock-local-storage './{,!(node_modules)/**}/*.test.js'",
"lint": "eslint **/*.js", "lint": "eslint '**/*.js'",
"fix-style": "eslint --fix '**/*.js'" "fix-style": "eslint --fix **/*.js",
"lintHTML": "htmlhint '**/*.html'",
"lintCSS": "stylelint '**/*.css'"
}, },
"devDependencies": { "devDependencies": {
"eslint": "^8.27.0", "eslint": "^8.27.0",
"htmlhint": "1.1.4",
"mocha": "10", "mocha": "10",
"mock-local-storage": "^1.1.23" "mock-local-storage": "^1.1.23",
"stylelint": "14.14.1",
"stylelint-config-standard": "^29.0.0"
} }
} }