mirror of
				https://github.com/cse110-fa22-group29/cse110-fa22-group29.git
				synced 2025-10-30 19:46:49 +00:00 
			
		
		
		
	fix locality issue in mocha unit tests,
move sample helper functions for localStorage unit testing Signed-off-by: Arthur Lu <learthurgo@gmail.com>
This commit is contained in:
		| @@ -1,27 +1,13 @@ | |||||||
| const {environment} = require("./testenv.js"); | const {environment} = require("./testenv.js"); | ||||||
| var assert = require('assert'); | var assert = require('assert'); | ||||||
| var window; | var {saveToLocal, getFromLocal, removeFromLocal, clearLocal} = require('./testenv_helpers'); | ||||||
|  |  | ||||||
| function saveToLocal (k, v) { | beforeEach(() => { | ||||||
| 	window.localStorage.setItem(k, v); | 	window = environment(); | ||||||
| } | }); | ||||||
|  |  | ||||||
| function getFromLocal (k) { |  | ||||||
| 	return window.localStorage.getItem(k); |  | ||||||
| } |  | ||||||
|  |  | ||||||
| function removeFromLocal (k) { |  | ||||||
| 	window.localStorage.removeItem(k); |  | ||||||
| } |  | ||||||
|  |  | ||||||
| function clearLocal () { |  | ||||||
| 	window.localStorage.clear(); |  | ||||||
| }  |  | ||||||
|  |  | ||||||
| describe("test localStorage mock", () => { | describe("test localStorage mock", () => { | ||||||
| 	it("test save and fetch", () => { | 	it("test save and fetch", () => { | ||||||
| 		window = environment(); |  | ||||||
|  |  | ||||||
| 		saveToLocal("testkey1", "testvalue1"); | 		saveToLocal("testkey1", "testvalue1"); | ||||||
| 		saveToLocal("testkey2", "testvalue2"); | 		saveToLocal("testkey2", "testvalue2"); | ||||||
| 		saveToLocal("testkey3", "testvalue3"); | 		saveToLocal("testkey3", "testvalue3"); | ||||||
| @@ -37,8 +23,6 @@ describe("test localStorage mock", () => { | |||||||
| 	}); | 	}); | ||||||
|  |  | ||||||
| 	it("test window locality", () => { | 	it("test window locality", () => { | ||||||
| 		window = environment(); |  | ||||||
|  |  | ||||||
| 		assert.equal(getFromLocal("testkey1"), null); | 		assert.equal(getFromLocal("testkey1"), null); | ||||||
| 		assert.equal(getFromLocal("testkey2"), null); | 		assert.equal(getFromLocal("testkey2"), null); | ||||||
| 		assert.equal(getFromLocal("testkey3"), null); | 		assert.equal(getFromLocal("testkey3"), null); | ||||||
| @@ -46,8 +30,6 @@ describe("test localStorage mock", () => { | |||||||
| 	}); | 	}); | ||||||
|  |  | ||||||
| 	it("test delete and fetch", () => { | 	it("test delete and fetch", () => { | ||||||
| 		window = environment(); |  | ||||||
|  |  | ||||||
| 		saveToLocal("testkey1", "testvalue1"); | 		saveToLocal("testkey1", "testvalue1"); | ||||||
| 		saveToLocal("testkey2", "testvalue2"); | 		saveToLocal("testkey2", "testvalue2"); | ||||||
| 		saveToLocal("testkey3", "testvalue3"); | 		saveToLocal("testkey3", "testvalue3"); | ||||||
| @@ -83,8 +65,6 @@ describe("test localStorage mock", () => { | |||||||
| 	}); | 	}); | ||||||
|  |  | ||||||
| 	it("test clear and fetch", () => { | 	it("test clear and fetch", () => { | ||||||
| 		window = environment(); |  | ||||||
|  |  | ||||||
| 		saveToLocal("testkey1", "testvalue1"); | 		saveToLocal("testkey1", "testvalue1"); | ||||||
| 		saveToLocal("testkey2", "testvalue2"); | 		saveToLocal("testkey2", "testvalue2"); | ||||||
| 		saveToLocal("testkey3", "testvalue3"); | 		saveToLocal("testkey3", "testvalue3"); | ||||||
|   | |||||||
							
								
								
									
										17
									
								
								testenv/testenv_helpers.js
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										17
									
								
								testenv/testenv_helpers.js
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,17 @@ | |||||||
|  | module.exports = {saveToLocal, getFromLocal, removeFromLocal, clearLocal}; | ||||||
|  |  | ||||||
|  | function saveToLocal (k, v) { | ||||||
|  | 	window.localStorage.setItem(k, v); | ||||||
|  | } | ||||||
|  |  | ||||||
|  | function getFromLocal (k) { | ||||||
|  | 	return window.localStorage.getItem(k); | ||||||
|  | } | ||||||
|  |  | ||||||
|  | function removeFromLocal (k) { | ||||||
|  | 	window.localStorage.removeItem(k); | ||||||
|  | } | ||||||
|  |  | ||||||
|  | function clearLocal () { | ||||||
|  | 	window.localStorage.clear(); | ||||||
|  | }  | ||||||
		Reference in New Issue
	
	Block a user