From 6d8dc935436f695d6f5cff5991b4fb3c526be357 Mon Sep 17 00:00:00 2001 From: Arthur Lu Date: Sun, 4 Dec 2022 19:31:27 -0800 Subject: [PATCH 1/5] try nyc --- .github/workflows/js-unittest.yml | 4 ++-- .gitignore | 3 ++- package.json | 2 ++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/js-unittest.yml b/.github/workflows/js-unittest.yml index daaab10..fc39c95 100644 --- a/.github/workflows/js-unittest.yml +++ b/.github/workflows/js-unittest.yml @@ -25,5 +25,5 @@ jobs: run: sudo npm install - name: Start local http server run: sudo npm run http-server & - - name: Run tests - run: sudo npm test + - name: Run tests with coverage + run: sudo npm run coverage diff --git a/.gitignore b/.gitignore index ea296b8..fc83b8e 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,5 @@ **/.devcontainer/* **/node_modules/* **/package-lock.json -**/*.vscode/* \ No newline at end of file +**/.vscode/* +**/.nyc_output/* \ No newline at end of file diff --git a/package.json b/package.json index 719337f..1d9daa4 100644 --- a/package.json +++ b/package.json @@ -4,6 +4,7 @@ "type": "module", "scripts": { "test": "mocha --recursive --require mock-local-storage './{,!(node_modules)/**}/*.test.js'", + "coverage": "nyc --all npm run test", "lint-js": "eslint **/*.js", "fix-js": "eslint --fix **/*.js", "lint-html": "htmlhint **/*.html", @@ -20,6 +21,7 @@ "http-server": "", "mocha": "10", "mock-local-storage": "^1.1.23", + "nyc": "^14.0.0", "prettier": "2.8.0", "puppeteer": "^18.2.1", "stylelint": "14.14.1", From 35c8619f874ce3bc66055032a04a2e9592ecdc92 Mon Sep 17 00:00:00 2001 From: Arthur Lu Date: Sun, 4 Dec 2022 19:38:52 -0800 Subject: [PATCH 2/5] switch to c8 --- .gitignore | 3 ++- package.json | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index fc83b8e..7dd6a0b 100644 --- a/.gitignore +++ b/.gitignore @@ -2,4 +2,5 @@ **/node_modules/* **/package-lock.json **/.vscode/* -**/.nyc_output/* \ No newline at end of file +**/.nyc_output/* +**/coverage/* \ No newline at end of file diff --git a/package.json b/package.json index 1d9daa4..a514b38 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "type": "module", "scripts": { "test": "mocha --recursive --require mock-local-storage './{,!(node_modules)/**}/*.test.js'", - "coverage": "nyc --all npm run test", + "coverage": "c8 npm run test", "lint-js": "eslint **/*.js", "fix-js": "eslint --fix **/*.js", "lint-html": "htmlhint **/*.html", @@ -16,12 +16,12 @@ "js-doc": "jsdoc -d source/docs/ -r source/" }, "devDependencies": { + "c8": "^7.12.0", "eslint": "^8.27.0", "htmlhint": "1.1.4", "http-server": "", "mocha": "10", "mock-local-storage": "^1.1.23", - "nyc": "^14.0.0", "prettier": "2.8.0", "puppeteer": "^18.2.1", "stylelint": "14.14.1", From 08bd1dc3ba3690c461ed1e9c03db320d6f95d5e7 Mon Sep 17 00:00:00 2001 From: Arthur Lu Date: Sun, 4 Dec 2022 19:44:30 -0800 Subject: [PATCH 3/5] add coverage check, try permision fix --- .github/workflows/js-unittest.yml | 2 ++ package.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/js-unittest.yml b/.github/workflows/js-unittest.yml index fc39c95..3234bc9 100644 --- a/.github/workflows/js-unittest.yml +++ b/.github/workflows/js-unittest.yml @@ -23,6 +23,8 @@ jobs: uses: actions/checkout@v3 - name: Install dependencies run: sudo npm install + - name: Give permissions to npm folder + run: sudo chown -R 1001:123 "/root/.npm" - name: Start local http server run: sudo npm run http-server & - name: Run tests with coverage diff --git a/package.json b/package.json index a514b38..44dc522 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "type": "module", "scripts": { "test": "mocha --recursive --require mock-local-storage './{,!(node_modules)/**}/*.test.js'", - "coverage": "c8 npm run test", + "coverage": "c8 --check-coverage --lines 90 --functions 90 --branches 90 npm run test", "lint-js": "eslint **/*.js", "fix-js": "eslint --fix **/*.js", "lint-html": "htmlhint **/*.html", From cb5882a04f98ccb94dde5ca0c16ea9ff2d62818b Mon Sep 17 00:00:00 2001 From: Arthur Lu Date: Sun, 4 Dec 2022 19:49:21 -0800 Subject: [PATCH 4/5] try loglevel verbose --- .github/workflows/js-unittest.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/js-unittest.yml b/.github/workflows/js-unittest.yml index 3234bc9..e51538d 100644 --- a/.github/workflows/js-unittest.yml +++ b/.github/workflows/js-unittest.yml @@ -23,9 +23,7 @@ jobs: uses: actions/checkout@v3 - name: Install dependencies run: sudo npm install - - name: Give permissions to npm folder - run: sudo chown -R 1001:123 "/root/.npm" - name: Start local http server run: sudo npm run http-server & - name: Run tests with coverage - run: sudo npm run coverage + run: sudo npm run coverage --loglevel=verbose From 0d27862c89a158732ace9cd468f71412578cd43f Mon Sep 17 00:00:00 2001 From: Arthur Lu Date: Sun, 4 Dec 2022 19:52:41 -0800 Subject: [PATCH 5/5] try no sudo --- .github/workflows/js-unittest.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/js-unittest.yml b/.github/workflows/js-unittest.yml index e51538d..0d746b9 100644 --- a/.github/workflows/js-unittest.yml +++ b/.github/workflows/js-unittest.yml @@ -22,8 +22,8 @@ jobs: - name: Checkout uses: actions/checkout@v3 - name: Install dependencies - run: sudo npm install + run: npm install - name: Start local http server - run: sudo npm run http-server & + run: npm run http-server & - name: Run tests with coverage - run: sudo npm run coverage --loglevel=verbose + run: npm run coverage