From 1cdaa63935d3f70bc3a8e56ed4e52170ddaf1f56 Mon Sep 17 00:00:00 2001
From: Kara Hoagland <khoaglan@ucsd.edu>
Date: Tue, 29 Nov 2022 14:16:17 -0800
Subject: [PATCH] delete tag bug

---
 source/assets/scripts/CreatePage.js    |  3 ++-
 source/assets/scripts/ReviewDetails.js | 12 +++++++-----
 source/assets/scripts/localStorage.js  | 14 +++++++-------
 3 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/source/assets/scripts/CreatePage.js b/source/assets/scripts/CreatePage.js
index e1850f5..b60a016 100644
--- a/source/assets/scripts/CreatePage.js
+++ b/source/assets/scripts/CreatePage.js
@@ -92,7 +92,8 @@ function initFormHandler() {
 	tagAddBtn.addEventListener("click", ()=> {
 		let tagField = document.getElementById("tag-form");
 		if (tagField.value.length > 0) {
-			if (!tagSet.has(tagField.value.toLowerCase())){
+			let tagSetVal = tagField.value.toLowerCase();
+			if (!tagSet.has(tagSetVal)){
 				let tagLabel = document.createElement("label");
 				tagLabel.innerHTML = tagField.value;
 				tagLabel.setAttribute("class","tag");
diff --git a/source/assets/scripts/ReviewDetails.js b/source/assets/scripts/ReviewDetails.js
index 1f83c82..c9e05a0 100644
--- a/source/assets/scripts/ReviewDetails.js
+++ b/source/assets/scripts/ReviewDetails.js
@@ -99,14 +99,15 @@ function setupUpdate(){
 			while (tagContainer.firstChild) {
 				tagContainer.removeChild(tagContainer.firstChild);
 			}
+			let tagSetVal = currReview["tags"][i].toLowerCase()
 			for (let i = 0; i < currReview["tags"].length; i++) {
-				tagSet.add(currReview["tags"][i].toLowerCase());
+				tagSet.add(tagSetVal);
 				let newTag = document.createElement("label");
 				newTag.setAttribute("class","tag");
 				newTag.innerHTML = currReview["tags"][i];
 				newTag.addEventListener("click",()=> {
 					tagContainer.removeChild(newTag);
-					tagSet.delete(currReview["tags"][i].toLowerCase());
+					tagSet.delete(tagSetVal);
 				});
 				tagContainer.append(newTag);
 			}
@@ -195,14 +196,15 @@ function setupUpdate(){
 		tagAddBtn.addEventListener("click", ()=> {
 			let tagField = document.getElementById("tag-form");
 			if (tagField.value.length > 0) {
-				if (!tagSet.has(tagField.value.toLowerCase())){
+				let tagSetVal = tagField.value.toLowerCase();
+				if (!tagSet.has(tagSetVal)){
 					let tagLabel = document.createElement("label");
 					tagLabel.innerHTML = tagField.value;
 					tagLabel.setAttribute("class","tag");
-					tagSet.add(tagField.value.toLowerCase());
+					tagSet.add(tagSetVal);
 					tagLabel.addEventListener("click",()=> {
 						tagContainer.removeChild(tagLabel);
-						tagSet.delete(tagField.value.toLowerCase());
+						tagSet.delete(tagSetVal);
 					});
 			
 					tagContainer.append(tagLabel);
diff --git a/source/assets/scripts/localStorage.js b/source/assets/scripts/localStorage.js
index 8ccfe4e..80709d2 100644
--- a/source/assets/scripts/localStorage.js
+++ b/source/assets/scripts/localStorage.js
@@ -81,8 +81,8 @@ export function deleteReviewFromStorage(ID){
 function deleteTagsFromStorage(ID, deletedTags) {
 	for(let i in deletedTags){
 		//get local storage of each tag and remove id from tag list
-		let tagName = "!"+ deletedTags[i];
-		let tagArr = JSON.parse(localStorage.getItem(tagName.toLowerCase()));
+		let tagName = "!"+ deletedTags[i].toLowerCase();
+		let tagArr = JSON.parse(localStorage.getItem(tagName));
 		for(let j in tagArr){
 			if(tagArr[j] == ID){
 				tagArr.splice(j,1);
@@ -90,9 +90,9 @@ function deleteTagsFromStorage(ID, deletedTags) {
 			break;
 		}
 		if(tagArr.length != 0){
-			localStorage.setItem(tagName.toLowerCase(), JSON.stringify(tagArr));
+			localStorage.setItem(tagName, JSON.stringify(tagArr));
 		} else {
-			localStorage.removeItem(tagName.toLowerCase());
+			localStorage.removeItem(tagName);
 		}
 	}
 }
@@ -104,13 +104,13 @@ function deleteTagsFromStorage(ID, deletedTags) {
  */
 function addTagsToStorage(ID, addedTags) {
 	for(let i in addedTags){
-		let tagName = "!" + addedTags[i];
-		let tagArr = JSON.parse(localStorage.getItem(tagName.toLowerCase()));
+		let tagName = "!" + addedTags[i].toLowerCase();
+		let tagArr = JSON.parse(localStorage.getItem(tagName));
 		if(!tagArr){
 			tagArr = [];
 		}
 		tagArr.push(ID);
-		localStorage.setItem(tagName.toLowerCase(), JSON.stringify(tagArr));
+		localStorage.setItem(tagName, JSON.stringify(tagArr));
 	}
 }